Fix spam detection

Author: InfinityGhost

TabletBot.Discord/Watchers/Spam/SpamMessageList.cs

@@ -19,13 +19,13 @@ public bool Check(IMessage message)
             if (GetLastUserMessage(message.Author) is SpamWatcherItem item)
             {
                 var since = item.Message.Timestamp - message.Timestamp;
-                if (item.Message.CleanContent == message.CleanContent && since > TimeSpan.FromSeconds(30))
+                if (item.Message.CleanContent == message.CleanContent && since < TimeSpan.FromSeconds(30))
                 {
                     item.Count++;
                 }
                 else
                 {
-                    item.Count = 0;
+                    item.Count = 1;
                     item.Message = message;
                 }
                 return item.Count >= Settings.Current.SpamThreshold;
@@ -40,15 +40,9 @@ public bool Check(IMessage message)
             return false;
         }
 
-        private bool ContainsUrl(string messageContent)
-        {
-            var subStrings = messageContent.Split(' ');
-            return subStrings.Any(m => m.Contains("http://") || m.Contains("https://"));
-        }
-
         private SpamWatcherItem? GetLastUserMessage(IUser user)
         {
-            return this.FirstOrDefault(m => m.Message.Author.Discriminator == user.Discriminator);
+            return this.FirstOrDefault(m => m.Message.Author.Id == user.Id);
         }
     }
 }

TabletBot.Discord/Watchers/Spam/SpamMessageWatcher.cs

@@ -1,5 +1,6 @@
 using System.Threading.Tasks;
 using Discord;
+using TabletBot.Common;
 
 #nullable enable
 
@@ -12,7 +13,8 @@ public async Task Receive(IMessage message)
             if (_spamMessageList.Check(message))
             {
                 var guildUser = message.Author as IGuildUser;
-                await guildUser.BanAsync();
+                await guildUser.BanAsync(1, "Automated ban for spam.");
+                Log.Write("SpamDetect", $"User {guildUser.Username}#{guildUser.Discriminator} ({guildUser.Id}) was banned for spamming.");
             }
         }