Fix ephemeral responses

Author: InfinityGhost

TabletBot.Discord/SlashCommands/ModerationSlashCommands.cs

@@ -21,6 +21,7 @@ protected override IEnumerable<SlashCommand> GetSlashCommands()
             {
                 Name = DELETE,
                 Handler = Delete,
+                Ephemeral = true,
                 MinimumPermissions = GuildPermissions.None.Modify(
                     manageMessages: true
                 ),
@@ -45,6 +46,7 @@ protected override IEnumerable<SlashCommand> GetSlashCommands()
             {
                 Name = KICK_USER,
                 Handler = Kick,
+                Ephemeral = true,
                 MinimumPermissions = GuildPermissions.None.Modify(
                     kickMembers: true
                 ),
@@ -76,6 +78,7 @@ protected override IEnumerable<SlashCommand> GetSlashCommands()
             {
                 Name = BAN_USER,
                 Handler = Ban,
+                Ephemeral = true,
                 MinimumPermissions = GuildPermissions.None.Modify(
                     banMembers: true
                 ),
@@ -107,6 +110,7 @@ protected override IEnumerable<SlashCommand> GetSlashCommands()
             {
                 Name = CREATE_EMBED,
                 Handler = CreateEmbed,
+                Ephemeral = false,
                 MinimumPermissions = GuildPermissions.None.Modify(
                     sendTTSMessages: true
                 ),
@@ -169,7 +173,7 @@ private async Task Delete(SocketSlashCommand command)
 
             var messages = await command.Channel.GetMessagesAsync(amount).FlattenAsync();
             await (command.Channel as ITextChannel).DeleteMessagesAsync(messages);
-            await command.FollowupAsync($"Deleted {amount} messages.", ephemeral: true);
+            await command.FollowupAsync($"Deleted {amount} messages.");
         }
 
         private async Task Kick(SocketSlashCommand command)
@@ -181,16 +185,13 @@ private async Task Kick(SocketSlashCommand command)
             {
                 await user.KickAsync(reason);
                 if (reason != null)
-                    await command.FollowupAsync($"Kicked {user.Mention} for \"{reason}\".", ephemeral: true);
+                    await command.FollowupAsync($"Kicked {user.Mention} for \"{reason}\".");
                 else
-                    await command.FollowupAsync($"Kicked {user.Mention}.", ephemeral: true);
+                    await command.FollowupAsync($"Kicked {user.Mention}.");
             }
             else
             {
-                await command.FollowupAsync(
-                    $"This user is not a member of this guild.",
-                    ephemeral: true
-                );
+                await command.FollowupAsync("This user is not a member of this guild.");
             }
         }
 
@@ -205,16 +206,13 @@ private async Task Ban(SocketSlashCommand command)
             {
                 await user.BanAsync(reason: reason);
                 if (reason != null)
-                    await command.FollowupAsync($"Banned {user.Mention} for \"{reason}\".", ephemeral: true);
+                    await command.FollowupAsync($"Banned {user.Mention} for \"{reason}\".");
                 else
-                    await command.FollowupAsync($"Banned {user.Mention}.", ephemeral: true);
+                    await command.FollowupAsync($"Banned {user.Mention}.");
             }
             else
             {
-                await command.FollowupAsync(
-                    $"This user is not a member of this guild.",
-                    ephemeral: true
-                );
+                await command.FollowupAsync("This user is not a member of this guild.");
             }
         }
 

TabletBot.Discord/SlashCommands/SlashCommand.cs

@@ -12,12 +12,13 @@ public class SlashCommand
         public SlashCommandBuilder Builder { set; get; }
         public Func<SocketSlashCommand, Task> Handler { set; get; }
         public GuildPermissions? MinimumPermissions { set; get; }
+        public bool Ephemeral { set; get; }
 
         public SlashCommandProperties Build() => Builder.Build();
 
         public async Task Invoke(SocketSlashCommand command)
         {
-            await command.DeferAsync(true);
+            await command.DeferAsync(Ephemeral);
             if (MinimumPermissions is GuildPermissions permissions)
             {
                 var user = command.User as IGuildUser;
@@ -27,7 +28,7 @@ public async Task Invoke(SocketSlashCommand command)
                 }
                 else
                 {
-                    await command.FollowupAsync("You do not have permissions to use this command.", ephemeral: true);
+                    await command.FollowupAsync("You do not have permissions to use this command.");
                 }
             }
             else

TabletBot.Discord/SlashCommands/SnippetSlashCommands.cs

@@ -144,7 +144,7 @@ private async Task ShowSnippet(SocketSlashCommand command)
             var snippet = command.GetValue<string>("snippet");
 
             if (SnippetEmbeds.TryGetSnippetEmbed(_settings, snippet, out var embed))
-                await command.FollowupAsync(embed: embed.Build());
+                await command.FollowupAsync(embed: embed.Build(), ephemeral: false);
             else
                 await command.FollowupAsync("Could not find snippet");
         }

TabletBot.Discord/SlashCommands/UserSlashCommands.cs

@@ -16,6 +16,7 @@ protected override IEnumerable<SlashCommand> GetSlashCommands()
             {
                 Name = SET_TABLET,
                 Handler = SetTablet,
+                Ephemeral = true,
                 Builder = new SlashCommandBuilder
                 {
                     Name = SET_TABLET,
@@ -42,12 +43,12 @@ private async Task SetTablet(SocketSlashCommand command)
             if (tablet != null)
             {
                 await user.ModifyAsync(u => u.Nickname = $"{user.Username} | {tablet}");
-                await command.FollowupAsync($"Your nickname has updated to include your tablet.", ephemeral: true);
+                await command.FollowupAsync($"Your nickname has updated to include your tablet.");
             }
             else
             {
                 await user.ModifyAsync(u => u.Nickname = null);
-                await command.FollowupAsync($"Your nickname has been reset.", ephemeral: true);
+                await command.FollowupAsync($"Your nickname has been reset.");
             }
         }
     }