Skip to content

Commit ec9b5a0

Browse files
Riksu9000JF002
authored andcommitted
Move radio button styling to a single place
1 parent 736ae08 commit ec9b5a0

6 files changed

Lines changed: 24 additions & 18 deletions

File tree

src/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -434,6 +434,7 @@ list(APPEND SOURCE_FILES
434434
displayapp/screens/PassKey.cpp
435435
displayapp/screens/Error.cpp
436436
displayapp/screens/Alarm.cpp
437+
displayapp/screens/Styles.cpp
437438
displayapp/Colors.cpp
438439

439440
## Settings

src/displayapp/screens/Styles.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
#include "Styles.h"
2+
3+
void Pinetime::Applications::Screens::SetRadioButtonStyle(lv_obj_t* checkbox) {
4+
lv_obj_set_style_local_radius(checkbox, LV_CHECKBOX_PART_BULLET, LV_STATE_DEFAULT, LV_RADIUS_CIRCLE);
5+
lv_obj_set_style_local_border_width(checkbox, LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, 9);
6+
lv_obj_set_style_local_border_color(checkbox, LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, LV_COLOR_GREEN);
7+
lv_obj_set_style_local_bg_color(checkbox, LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, LV_COLOR_WHITE);
8+
}

src/displayapp/screens/Styles.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
#include <lvgl/lvgl.h>
2+
3+
namespace Pinetime {
4+
namespace Applications {
5+
namespace Screens {
6+
void SetRadioButtonStyle(lv_obj_t* checkbox);
7+
}
8+
}
9+
}

src/displayapp/screens/settings/SettingDisplay.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
#include <lvgl/lvgl.h>
33
#include "displayapp/DisplayApp.h"
44
#include "displayapp/Messages.h"
5+
#include "displayapp/screens/Styles.h"
56
#include "displayapp/screens/Screen.h"
67
#include "displayapp/screens/Symbols.h"
78

@@ -49,12 +50,7 @@ SettingDisplay::SettingDisplay(Pinetime::Applications::DisplayApp* app, Pinetime
4950
lv_checkbox_set_text(cbOption[i], buffer);
5051
cbOption[i]->user_data = this;
5152
lv_obj_set_event_cb(cbOption[i], event_handler);
52-
53-
// radio button style
54-
lv_obj_set_style_local_radius(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_DEFAULT, LV_RADIUS_CIRCLE);
55-
lv_obj_set_style_local_border_width(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, 9);
56-
lv_obj_set_style_local_border_color(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, LV_COLOR_GREEN);
57-
lv_obj_set_style_local_bg_color(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, LV_COLOR_WHITE);
53+
SetRadioButtonStyle(cbOption[i]);
5854

5955
if (settingsController.GetScreenTimeOut() == options[i]) {
6056
lv_checkbox_set_checked(cbOption[i], true);

src/displayapp/screens/settings/SettingTimeFormat.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#include "displayapp/screens/settings/SettingTimeFormat.h"
22
#include <lvgl/lvgl.h>
33
#include "displayapp/DisplayApp.h"
4+
#include "displayapp/screens/Styles.h"
45
#include "displayapp/screens/Screen.h"
56
#include "displayapp/screens/Symbols.h"
67

@@ -46,12 +47,7 @@ SettingTimeFormat::SettingTimeFormat(Pinetime::Applications::DisplayApp* app, Pi
4647
lv_checkbox_set_text(cbOption[i], options[i]);
4748
cbOption[i]->user_data = this;
4849
lv_obj_set_event_cb(cbOption[i], event_handler);
49-
50-
// radio button style
51-
lv_obj_set_style_local_radius(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_DEFAULT, LV_RADIUS_CIRCLE);
52-
lv_obj_set_style_local_border_width(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, 9);
53-
lv_obj_set_style_local_border_color(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, LV_COLOR_GREEN);
54-
lv_obj_set_style_local_bg_color(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, LV_COLOR_WHITE);
50+
SetRadioButtonStyle(cbOption[i]);
5551
}
5652

5753
if (settingsController.GetClockType() == Controllers::Settings::ClockType::H12) {

src/displayapp/screens/settings/SettingWatchFace.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
#include <lvgl/lvgl.h>
33
#include "displayapp/DisplayApp.h"
44
#include "displayapp/screens/Screen.h"
5+
#include "displayapp/screens/Styles.h"
56
#include "displayapp/screens/Symbols.h"
67

78
using namespace Pinetime::Applications::Screens;
@@ -47,12 +48,7 @@ SettingWatchFace::SettingWatchFace(Pinetime::Applications::DisplayApp* app, Pine
4748
lv_checkbox_set_text(cbOption[i], options[i]);
4849
cbOption[i]->user_data = this;
4950
lv_obj_set_event_cb(cbOption[i], event_handler);
50-
51-
// radio button style
52-
lv_obj_set_style_local_radius(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_DEFAULT, LV_RADIUS_CIRCLE);
53-
lv_obj_set_style_local_border_width(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, 9);
54-
lv_obj_set_style_local_border_color(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, LV_COLOR_GREEN);
55-
lv_obj_set_style_local_bg_color(cbOption[i], LV_CHECKBOX_PART_BULLET, LV_STATE_CHECKED, LV_COLOR_WHITE);
51+
SetRadioButtonStyle(cbOption[i]);
5652

5753
if (settingsController.GetClockFace() == i) {
5854
lv_checkbox_set_checked(cbOption[i], true);

0 commit comments

Comments
 (0)