|
2 | 2 | ## Report bugs |
3 | 3 | You use your Pinetime and find a bug in the firmware? [Create an issue on Github](https://github.com/JF002/InfiniTime/issues) explaining the bug, how to reproduce it, the version of the firmware you use... |
4 | 4 | ## Write and improve documentation |
5 | | -Documentation might be incomplete, or not clear enough, and it is always possible to improve it with better wording, pictures, photo, video,... |
| 5 | +Documentation might be incomplete, or not clear enough, and it is always possible to improve it with better wording, pictures, photo, video,... |
6 | 6 |
|
7 | 7 | As the documentation is part of the source code, you can submit your improvements to the documentation by submitting a pull request (see below). |
8 | 8 | ## Fix bugs, add functionalities and improve the code |
9 | 9 | You want to fix a bug, add a cool new functionality or improve the code? See *How to submit a pull request below*. |
10 | 10 | ## Spread the word |
11 | | -Pinetime is a cool open source project that deserves to be know. Talk about it around you, on social networks, on your blog,... and let people know that we are working on an open-source firmware for a smartwatch! |
| 11 | +The Pinetime is a cool open source project that deserves to be known. Talk about it around you, on social networks, on your blog,... and let people know that we are working on an open-source firmware for a smartwatch! |
12 | 12 |
|
13 | 13 | # How to submit a pull request ? |
14 | | -Your contribution is more than welcome! |
15 | 14 |
|
16 | | -If you want to fix a bug, add a functionality or improve the code, you'll first need to create a branch from the **develop** branch (see [this page about the branching model](./branches.md)). This branch is called a feature branch, and you should choose a name that explains what you are working on (ex: "add-doc-about-contributions"). In this branch, try to focus on only one topic, bug or feature. For example, if you created this branch to work on the UI of a specific application, do not commit modifications about the SPI driver. If you want to work on multiple topics, create one branch per topic. |
| 15 | +## TL;DR |
| 16 | + - Create a branch from develop; |
| 17 | + - Work on a single subject in this branch. Create multiple branches/pulls-requests if you want to work on multiple subjects (bugs, features,...); |
| 18 | + - Test your modifications on the actual hardware; |
| 19 | + - Check the code formatting against our coding conventions and [clang-format](../.clang-format) and [clang-tidy](../.clang-tidy); |
| 20 | + - Clean your code and remove files that are not needed; |
| 21 | + - Write documentation related to your new feature is applicable; |
| 22 | + - Create the pull-request and write a great description about it : what does your PR do, why, how,... Add pictures and video if possible; |
| 23 | + - Wait for someone to review your PR and take part in the review process; |
| 24 | + - Your PR will eventually be merged :) |
17 | 25 |
|
18 | | -When your feature branch is ready, make sure it actually works and do not forget to write documentation about it if necessary. |
| 26 | +Your contribution is more than welcome! |
19 | 27 |
|
20 | | -Then, you can submit a pull-request for review. Try to describe your pull request as much as possible: what did you do in this branch, how does it work, how is it designed, are there any limitations,... This will help the contributors to understand and review your code easily. |
| 28 | +If you want to fix a bug, add a functionality or improve the code, you'll first need to create a branch from the **develop** branch (see [this page about the branching model](./branches.md)). This branch is called a feature branch, and you should choose a name that explains what you are working on (ex: "add-doc-about-contributions"). In this branch, **focus on only one topic, bug or feature**. For example, if you created this branch to work on the UI of a specific application, do not commit modifications about the SPI driver. If you want to work on multiple topics, create one branch per topic. |
21 | 29 |
|
22 | | -Other contributors can post comments about the pull request, maybe ask for more info or adjustements in the code. |
| 30 | +When your feature branch is ready, **make sure it actually works** and **do not forget to write documentation** about it if it's relevant. |
23 | 31 |
|
24 | | -Once the pull request is reviewed an accepted, it'll be merge in **develop** and will be released in the next release version of the firmware. |
| 32 | +I **strongly discourage to create a PR containing modifications that haven't been tested**. If, for any reason, you cannot test your modifications but want to publish them anyway, **please mention it in the description**. This way, other contributors might be willing to test it and provide feedback about your code. |
| 33 | + |
| 34 | +Also, before submitting your PR, check the coding style of your code against the **coding conventions** detailed below. This project also provides [clang-format](../.clang-format) and [clang-tidy](../.clang-tidy) configuration files. You can use them to ensure correct formatting of your code. |
| 35 | + |
| 36 | +Do not forget to check the files you are going to commit and remove those who are not necessary (config files from your IDE, for example). Remove old comments, commented code,... |
| 37 | + |
| 38 | +Then, you can submit a pull-request for review. Try to **describe your pull request as much as possible**: what did you do in this branch, how does it work, how is it designed, are there any limitations,... This will help the contributors to understand and review your code easily. You can add pictures and video to the description so that contributors will have a quick overview of your work. |
| 39 | + |
| 40 | +Other contributors can post comments about the pull request, maybe ask for more info or adjustments in the code. |
| 41 | + |
| 42 | +Once the pull request is reviewed and accepted, it'll be merge in **develop** and will be released in the next release version of the firmware. |
| 43 | + |
| 44 | +## Why all these rules? |
| 45 | +Reviewing pull-requests is a **very time consuming task** for the creator of this project ([JF002](https://github.com/JF002)) and for other contributors who take the time to review them. Every little thing you do to make their lives easier will **increase the chances your PR will be merge quickly**. |
| 46 | + |
| 47 | +When reviewing PR, the author and contributors will first look at the **description**. If it's easy to understand what the PR does, why the modification is needed or interesting and how it's done, a good part of the work is already done : we understand the PR and its context. |
| 48 | + |
| 49 | +Then, reviewing **a few files that were modified for a single purpose** is a lot more easier than to review 30 files modified for many reasons (bug fix, UI improvements, typos in doc,...), even if all these changes make sense. Also, it's possible that we agree on some modification but not on some other, and we won't be able to merge the PR because of the changes that are not accepted. |
| 50 | + |
| 51 | +We do our best to keep the code as consistent as possible, and that mean we pay attention to the **formatting** of the code. If the code formatting is not consistent with our code base, we'll ask you to review it, which will take more time. |
| 52 | + |
| 53 | +The last step of the review consists in **testing** the modification. If it doesn't work out of the box, we'll ask your to review your code and to ensure that it works as expected. |
| 54 | + |
| 55 | +It's totally normal for a PR to need some more work even after it was created, that's why we review them. But every round trip takes time, and it's good practice to try to reduce them as much as possible by following those simple rules. |
25 | 56 |
|
26 | 57 | # Coding convention |
27 | 58 | ## Language |
28 | 59 | The language of this project is **C++**, and all new code must be written in C++. (Modern) C++ provides a lot of useful tools and functionalities that are beneficial for embedded software development like `constexpr`, `template` and anything that provides zero-cost abstraction. |
29 | 60 |
|
30 | | -It's OK to include C code if this code comes from another library like FreeRTOS, NimBLE, LVGL or the NRF-SDK. |
| 61 | +It's OK to include C code if this code comes from another library like FreeRTOS, NimBLE, LVGL or the NRF-SDK. |
31 | 62 |
|
32 | 63 | ## Coding style |
33 | | -The most important rule to follow is to try to keep the code as easy to read and maintain as possible. |
| 64 | +The most important rule to follow is to try to keep the code as easy to read and maintain as possible. |
34 | 65 |
|
35 | | - - **Identation** : 2 spaces, no tabulation |
| 66 | + - **Indentation** : 2 spaces, no tabulation |
36 | 67 | - **Opening brace** at the end of the line |
37 | 68 | - **Naming** : Choose self-describing variable name |
38 | 69 | - **class** : PascalCase |
|
0 commit comments