Skip to content

Commit 63477fc

Browse files
committed
Fix unsigned/signed comparison warning in Metronome.cpp
`xTaskGetTickCount()` returns a `TickType_t`, which is defined as an `uint32_t`. This is compared to the `bpm` variable, which is a `int16_t` in the range of 40 to 220 as defined in the constructor. ```cpp lv_arc_set_range(bpmArc, 40, 220); ``` Just assume that `bpm` is greater than 0, as this would result in a divison by zero or negative values, which would unintentionally underflow to a very large number.
1 parent 3eb7377 commit 63477fc

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/displayapp/screens/Metronome.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ Metronome::~Metronome() {
7878

7979
void Metronome::Refresh() {
8080
if (metronomeStarted) {
81-
if (xTaskGetTickCount() - startTime > 60 * configTICK_RATE_HZ / bpm) {
81+
if (xTaskGetTickCount() - startTime > 60u * configTICK_RATE_HZ / static_cast<uint16_t>(bpm)) {
8282
startTime += 60 * configTICK_RATE_HZ / bpm;
8383
counter--;
8484
if (counter == 0) {

0 commit comments

Comments
 (0)