Skip to content

Commit 5171689

Browse files
committed
Twos: fix warning about extra paranthesis
We have a comparison like `if (( a == b ))`, which is a parenthesis too much, which generates the following warning ``` InfiniTime/src/displayapp/screens/Twos.cpp:133:35: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((grid[newRow][newCol].value == grid[oldRow][oldCol].value)) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ InfiniTime/src/displayapp/screens/Twos.cpp:133:35: note: remove extraneous parentheses around the comparison to silence this warning if ((grid[newRow][newCol].value == grid[oldRow][oldCol].value)) { ~ ^ ~ ```
1 parent 21da586 commit 5171689

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/displayapp/screens/Twos.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ bool Twos::placeNewTile() {
130130
}
131131

132132
bool Twos::tryMerge(TwosTile grid[][4], int& newRow, int& newCol, int oldRow, int oldCol) {
133-
if ((grid[newRow][newCol].value == grid[oldRow][oldCol].value)) {
133+
if (grid[newRow][newCol].value == grid[oldRow][oldCol].value) {
134134
if ((newCol != oldCol) || (newRow != oldRow)) {
135135
if (!grid[newRow][newCol].merged) {
136136
unsigned int newVal = grid[oldRow][oldCol].value *= 2;

0 commit comments

Comments
 (0)