Merge pull request #206 from nscooling/Hrs3300_SetGain_remove_warnings

JF002 · web-flow · commit 3a1ccdb43ed8 · 2021-02-14T14:27:14.000+01:00
Eliminated warnings in Hrs3300
diff --git a/src/drivers/Hrs3300.cpp b/src/drivers/Hrs3300.cpp
@@ -70,13 +70,14 @@ uint16_t Hrs3300::ReadAls() {
 }
 
 void Hrs3300::SetGain(uint8_t gain) {
-  static constexpr uint8_t maxGain = 64;
+  constexpr uint8_t maxGain = 64U;
   gain = std::min(gain, maxGain);
   uint8_t hgain = 0;
-  while((1 << hgain) < gain) {
-    hgain++;
-    WriteRegister(static_cast<uint8_t>(Registers::Hgain), hgain << 2);
+  while((1 << hgain) < gain){
+    ++hgain;
   }
+
+  WriteRegister(static_cast<uint8_t>(Registers::Hgain), hgain << 2);
 }
 
 void Hrs3300::SetDrive(uint8_t drive) {

Original file line number	Diff line number	Diff line change
`@@ -70,13 +70,14 @@ uint16_t Hrs3300::ReadAls() {`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`void Hrs3300::SetGain(uint8_t gain) {`
`73`		`- static constexpr uint8_t maxGain = 64;`
	`73`	`+ constexpr uint8_t maxGain = 64U;`
`74`	`74`	`gain = std::min(gain, maxGain);`
`75`	`75`	`uint8_t hgain = 0;`
`76`		`- while((1 << hgain) < gain) {`
`77`		`- hgain++;`
`78`		`- WriteRegister(static_cast<uint8_t>(Registers::Hgain), hgain << 2);`
	`76`	`+ while((1 << hgain) < gain){`
	`77`	`+ ++hgain;`
`79`	`78`	`}`
	`79`	`+`
	`80`	`+ WriteRegister(static_cast<uint8_t>(Registers::Hgain), hgain << 2);`
`80`	`81`	`}`
`81`	`82`
`82`	`83`	`void Hrs3300::SetDrive(uint8_t drive) {`