Skip to content

Commit 242620b

Browse files
committed
Improve doc/contribute.md : add more info and TL;DR
1 parent bc9a782 commit 242620b

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

doc/contribute.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,18 @@ You want to fix a bug, add a cool new functionality or improve the code? See *Ho
1111
Pinetime is a cool open source project that deserves to be know. Talk about it around you, on social networks, on your blog,... and let people know that we are working on an open-source firmware for a smartwatch!
1212

1313
# How to submit a pull request ?
14+
15+
## TL;DR
16+
- Create a branch from develop;
17+
- Work on a single subject in this branch. Create multiple branches/pulls-requests if you want to work on multiple subjects (bugs, features,...);
18+
- Test your modifications on the actual hardware;
19+
- Check the code formatting against our coding conventions and [clang-format](../.clang-format) and [clang-tidy](../.clang-tidy);
20+
- Clean your code and remove files that are not needed;
21+
- Write documentation related to your new feature is applicable;
22+
- Create the pull-request and write a great description about it : what does your PR do, why, how,... Add pictures and video if possible;
23+
- Wait for someone to review your PR and take part in the review process;
24+
- You PR will eventually be merged :)
25+
1426
Your contribution is more than welcome!
1527

1628
If you want to fix a bug, add a functionality or improve the code, you'll first need to create a branch from the **develop** branch (see [this page about the branching model](./branches.md)). This branch is called a feature branch, and you should choose a name that explains what you are working on (ex: "add-doc-about-contributions"). In this branch, **focus on only one topic, bug or feature**. For example, if you created this branch to work on the UI of a specific application, do not commit modifications about the SPI driver. If you want to work on multiple topics, create one branch per topic.
@@ -21,6 +33,8 @@ I **strongly discourage to create a PR containing modifications that haven't bee
2133

2234
Also, before submitting your PR, check the coding style of your code against the **coding conventions** detailed below. This project also provides [clang-format](../.clang-format) and [clang-tidy](../.clang-tidy) configuration files. You can use them to ensure correct formatting of your code.
2335

36+
Do not forget to check the files you are going to commit and remove those who are not necessary (config files from your IDE, for example). Remove old comments, commented code,...
37+
2438
Then, you can submit a pull-request for review. Try to **describe your pull request as much as possible**: what did you do in this branch, how does it work, how is it designed, are there any limitations,... This will help the contributors to understand and review your code easily. You can add pictures and video to the description so that contributors will have a quick overview of you work.
2539

2640
Other contributors can post comments about the pull request, maybe ask for more info or adjustements in the code.

0 commit comments

Comments
 (0)