Merge pull request #711 from geekbozu/BatteryReadFix

JF002 · web-flow · commit 1159403aee31 · 2021-10-02T18:00:21.000+02:00
Remove static declaration on batteryValue preventing read attribute from updating.
diff --git a/src/components/ble/BatteryInformationService.cpp b/src/components/ble/BatteryInformationService.cpp
@@ -43,7 +43,7 @@ int BatteryInformationService::OnBatteryServiceRequested(uint16_t connectionHand
                                                          ble_gatt_access_ctxt* context) {
   if (attributeHandle == batteryLevelHandle) {
     NRF_LOG_INFO("BATTERY : handle = %d", batteryLevelHandle);
-    static uint8_t batteryValue = batteryController.PercentRemaining();
+    uint8_t batteryValue = batteryController.PercentRemaining();
     int res = os_mbuf_append(context->om, &batteryValue, 1);
     return (res == 0) ? 0 : BLE_ATT_ERR_INSUFFICIENT_RES;
   }

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ int BatteryInformationService::OnBatteryServiceRequested(uint16_t connectionHand`
`43`	`43`	`ble_gatt_access_ctxt* context) {`
`44`	`44`	`if (attributeHandle == batteryLevelHandle) {`
`45`	`45`	`NRF_LOG_INFO("BATTERY : handle = %d", batteryLevelHandle);`
`46`		`- static uint8_t batteryValue = batteryController.PercentRemaining();`
	`46`	`+ uint8_t batteryValue = batteryController.PercentRemaining();`
`47`	`47`	`int res = os_mbuf_append(context->om, &batteryValue, 1);`
`48`	`48`	`return (res == 0) ? 0 : BLE_ATT_ERR_INSUFFICIENT_RES;`
`49`	`49`	`}`