Return bad request if job type is not registered

Author: ethanhann

IntegrationEngine/Api/Controllers/CronTriggerController.cs

@@ -44,6 +44,8 @@ public IHttpActionResult PutCronTrigger(string id, CronTrigger trigger)
         {
             if (id != trigger.Id)
                 return BadRequest();
+            if (!EngineScheduler.IsJobTypeRegistered(trigger.JobType))
+                return BadRequest("Job type is invalid: " + trigger.JobType);
             if (!trigger.CronExpressionString.IsValidCronExpression())
                 return BadRequest("Cron expression is not valid: " + trigger.CronExpressionString);
             Repository.Update(trigger);
@@ -55,6 +57,8 @@ public IHttpActionResult PutCronTrigger(string id, CronTrigger trigger)
         [ResponseType(typeof(CronTrigger))]
         public IHttpActionResult PostCronTrigger(CronTrigger trigger)
         {
+            if (!EngineScheduler.IsJobTypeRegistered(trigger.JobType))
+                return BadRequest("Job type is invalid: " + trigger.JobType);
             if (!trigger.CronExpressionString.IsValidCronExpression())
                 return BadRequest("Cron expression is not valid: " + trigger.CronExpressionString);
             var triggerWithId = Repository.Insert(trigger);

IntegrationEngine/Api/Controllers/SimpleTriggerController.cs

@@ -50,6 +50,8 @@ public IHttpActionResult PutSimpleTrigger(string id, SimpleTrigger trigger)
         {
             if (id != trigger.Id)
                 return BadRequest();
+            if (!EngineScheduler.IsJobTypeRegistered(trigger.JobType))
+                return BadRequest("Job type is invalid: " + trigger.JobType);
             Repository.Update(trigger);
             EngineScheduler.ScheduleJobWithSimpleTrigger(trigger);
             return StatusCode(HttpStatusCode.NoContent);
@@ -59,6 +61,8 @@ public IHttpActionResult PutSimpleTrigger(string id, SimpleTrigger trigger)
         [ResponseType(typeof(SimpleTrigger))]
         public IHttpActionResult PostSimpleTrigger(SimpleTrigger trigger)
         {
+            if (!EngineScheduler.IsJobTypeRegistered(trigger.JobType))
+                return BadRequest("Job type is invalid: " + trigger.JobType);
             var triggerWithId = Repository.Insert(trigger);
             EngineScheduler.ScheduleJobWithSimpleTrigger(triggerWithId);
             return CreatedAtRoute("DefaultApi", new { id = triggerWithId.Id }, triggerWithId);

IntegrationEngine/Scheduler/EngineScheduler.cs

@@ -22,6 +22,17 @@ public void Start()
             Scheduler.Start();
         }
 
+        public Type GetRegisteredJobTypeByName(string jobTypeName)
+        {
+            var jobTypes = IntegrationJobTypes.Where(x => x.FullName == jobTypeName);
+            return jobTypes.Any() ? jobTypes.Single() : null;
+        }
+
+        public bool IsJobTypeRegistered(string jobTypeName)
+        {
+            return GetRegisteredJobTypeByName(jobTypeName) != null;
+        }
+
         public IJobDetail JobDetailFactory(Type jobType)
         {
             var integrationJob = Activator.CreateInstance(jobType) as IIntegrationJob;
@@ -36,15 +47,15 @@ public IJobDetail JobDetailFactory(Type jobType)
 
         public virtual void ScheduleJobWithCronTrigger(CronTrigger triggerDefinition)
         {
-            var jobType = IntegrationJobTypes.Where(x => x.FullName == triggerDefinition.JobType).First();
+            var jobType = GetRegisteredJobTypeByName(triggerDefinition.JobType);
             var jobDetail = JobDetailFactory(jobType);
             var trigger = CronTriggerFactory(triggerDefinition, jobType, jobDetail);
             TryScheduleJobWithTrigger(trigger, jobType, jobDetail);
         }
 
         public void ScheduleJobWithSimpleTrigger(SimpleTrigger triggerDefinition)
         {
-            var jobType = IntegrationJobTypes.Where(x => x.FullName == triggerDefinition.JobType).First();
+            var jobType = GetRegisteredJobTypeByName(triggerDefinition.JobType);
             var jobDetail = JobDetailFactory(jobType);
             var trigger = SimpleTriggerFactory(triggerDefinition, jobType, jobDetail);
             TryScheduleJobWithTrigger(trigger, jobType, jobDetail);

IntegrationEngine/Scheduler/IEngineScheduler.cs

@@ -10,5 +10,7 @@ public interface IEngineScheduler
         void Start();
         void ScheduleJobWithCronTrigger(CronTrigger triggerDefinition);
         void ScheduleJobWithSimpleTrigger(SimpleTrigger triggerDefinition);
+        bool IsJobTypeRegistered(string jobTypeName);
+        Type GetRegisteredJobTypeByName(string jobTypeName);
     }
 }