Refactor tests

Author: ethanhann

IntegrationEngine.Model.Tests/TriggerPropertyExtensionTest.cs

@@ -64,29 +64,29 @@ public void ShouldReturnUtcTimeZoneIfTimeZoneIdDoesNotExist()
         public void ShouldReturnHumanReadableCronSchedule()
         {
             var expected = "Every minute";
-            string timeZoneId = "* * * * *";
+            string cronExpression = "* * * * *";
 
-            var result = timeZoneId.GetHumanReadableCronSchedule();
+            var result = cronExpression.GetHumanReadableCronSchedule();
 
             Assert.That(result, Is.EqualTo(expected));
         }
 
         [Test]
         public void ShouldReturnEmptyStringIfCronExpressionIsNull()
         {
-            string timeZoneId = null;
+            string cronExpression = null;
 
-            var result = timeZoneId.GetHumanReadableCronSchedule();
+            var result = cronExpression.GetHumanReadableCronSchedule();
 
             Assert.That(result, Is.EqualTo(String.Empty));
         }
 
         [Test]
         public void ShouldReturnEmptyStringIfCronExpressionIsInvalidString()
         {
-            string timeZoneId = "foo";
+            string cronExpression = "foo";
 
-            var result = timeZoneId.GetTimeZoneInfo();
+            var result = cronExpression.GetTimeZoneInfo();
 
             Assert.That(result, Is.EqualTo(TimeZoneInfo.Utc));
         }

IntegrationEngine.Tests/IntegrationEngine.Tests.csproj

@@ -119,6 +119,10 @@
       <Project>{7D49353D-A68C-4ACA-A6A5-40B1C314C30E}</Project>
       <Name>IntegrationEngine</Name>
     </ProjectReference>
+    <ProjectReference Include="..\UnitTesting\UnitTesting.csproj">
+      <Project>{3a6e4fab-025b-450c-a286-911bad1f8e05}</Project>
+      <Name>UnitTesting</Name>
+    </ProjectReference>
   </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <Import Project="$(SolutionDir)\.nuget\NuGet.targets" Condition="Exists('$(SolutionDir)\.nuget\NuGet.targets')" />

IntegrationEngine.Tests/IntegrationJobFixture.cs

@@ -9,7 +9,9 @@ namespace IntegrationEngine.Tests
 {
     public class IntegrationJobFixture : IIntegrationJob
     {
+        public static Type Type { get { return typeof(IntegrationJobFixture); } }
+        public static string FullName { get { return Type.FullName; } }
         public void Run()
-        {}
+        {}        
     }
 }

IntegrationEngine.Tests/Scheduler/EngineSchedulerTest.cs

@@ -5,48 +5,49 @@
 using Quartz.Impl;
 using System;
 using System.Collections.Generic;
+using UnitTesting;
 
 namespace IntegrationEngine.Tests.Scheduler
 {
-    public class EngineSchedulerTest
+    public class EngineSchedulerTest : TestBase<EngineScheduler>
     {
-        [Test]
-        public void ShouldDeleteTrigger()
+        public CronTrigger CronTrigger { get; set; }
+        [SetUp]
+        public void SetUp()
         {
-            var jobType = typeof(IntegrationJobFixture);
-            var subject = new EngineScheduler() {
-                IntegrationJobTypes = new List<Type>() { jobType }
-            };
-            var trigger = new CronTrigger() {
+            CronTrigger = new CronTrigger() {
                 Id = "one",
-                JobType = jobType.FullName
+                JobType = IntegrationJobFixture.FullName,
+                CronExpressionString = "* * * * * ?",
             };
-            var scheduler = new Mock<IScheduler>();
-            scheduler.Setup(x => x.UnscheduleJob(It.Is<TriggerKey>(y => y.Name == trigger.Id && 
-                                                                        y.Group == trigger.JobType))).Returns(true);
-            subject.Scheduler = scheduler.Object;
+            Subject.IntegrationJobTypes = new List<Type>() { IntegrationJobFixture.Type };
+            Subject.Scheduler = StdSchedulerFactory.GetDefaultScheduler();
+        }
+
+        [Test]
+        public void ShouldScheduleCronTriggerWithoutAnExceptionThrown()
+        {
+            Subject.ScheduleJobWithCronTrigger(CronTrigger);
+        }
 
-            var result = subject.DeleteTrigger(trigger);
+        [Test]
+        public void ShouldDeleteTrigger()
+        {
+            //var scheduler = new Mock<IScheduler>();
+            //scheduler.Setup(x => x.UnscheduleJob(It.Is<TriggerKey>(y => y.Name == trigger.Id && 
+            //                                                            y.Group == trigger.JobType))).Returns(true);
+            //Subject.Scheduler = scheduler.Object;
+            Subject.ScheduleJobWithCronTrigger(CronTrigger);
+
+            var result = Subject.DeleteTrigger(CronTrigger);
 
             Assert.That(result, Is.True);
         }
 
         [Test]
         public void ShouldReturnFalseIfATriggerThatIsNotScheduledIsDeleted()
         {
-            var jobType = typeof(IntegrationJobFixture);
-            var subject = new EngineScheduler() {
-                IntegrationJobTypes = new List<Type>() { jobType },
-                Scheduler = StdSchedulerFactory.GetDefaultScheduler(),
-            };
-            var trigger = new CronTrigger()
-            {
-                Id = "one",
-                JobType = jobType.FullName
-            };
-            var scheduler = StdSchedulerFactory.GetDefaultScheduler();
-
-            var result = subject.DeleteTrigger(trigger);
+            var result = Subject.DeleteTrigger(CronTrigger);
 
             Assert.That(result, Is.False);
         }