Add more logging

Author: ethanhann

src/InEngine.Core/AbstractCommand.cs

@@ -1,8 +1,7 @@
 using System;
 using System.Linq;
 using System.Threading.Tasks;
-using CommandLine;
-using CommandLine.Text;
+using Common.Logging;
 using InEngine.Core.Exceptions;
 using InEngine.Core.IO;
 using InEngine.Core.LifeCycle;
@@ -13,6 +12,7 @@ namespace InEngine.Core
 {
     abstract public class AbstractCommand : IJob, IWrite, IHasCommandLifeCycle
     {
+        protected ILog Log { get; set; }
         public CommandLifeCycle CommandLifeCycle { get; set; }
         public Write Write { get; set; }
         public ProgressBar ProgressBar { get; internal set; }
@@ -23,6 +23,7 @@ abstract public class AbstractCommand : IJob, IWrite, IHasCommandLifeCycle
 
         protected AbstractCommand()
         {
+            Log = LogManager.GetLogger(GetType());
             ScheduleId = Guid.NewGuid().ToString();
             Name = GetType().FullName;
             SchedulerGroup = GetType().AssemblyQualifiedName;
@@ -53,6 +54,7 @@ public virtual void RunWithLifeCycle()
             }
             catch (Exception exception)
             {
+                Log.Error(this, exception);
                 Failed(exception);
                 throw new CommandFailedException("Command failed. See inner exception for details.", exception);
             }

src/InEngine.Core/PluginAssembly.cs

@@ -5,12 +5,15 @@
 using System.Reflection;
 using System.Threading;
 using CommandLine;
+using Common.Logging;
 using InEngine.Core.Exceptions;
 
 namespace InEngine.Core
 {
     public class PluginAssembly
     {
+        ILog Log { get; set; } = LogManager.GetLogger<PluginAssembly>();
+
         public Assembly Assembly { get; set; }
         public string Name { get { return Assembly.GetName().Name; } }
         public string Version { get { return Assembly.GetName().Version.ToString(); } }
@@ -34,6 +37,7 @@ public static PluginAssembly LoadFrom(string pluginName)
             }
             catch (Exception exception)
             {
+                LogManager.GetLogger<PluginAssembly>().Error(exception);
                 throw new PluginNotFoundException($"Plugin not found at {path}", exception);
             }
         }
@@ -50,6 +54,7 @@ public static List<PluginAssembly> Load<T>(bool shouldLoadCorePlugin = true) whe
             }
             catch (Exception exception)
             {
+                LogManager.GetLogger<PluginAssembly>().Error(exception);
                 throw new PluginNotFoundException("Could not load InEngine.Core plugin.", exception);
             }
 

src/InEngine/ArgumentInterpreter.cs

@@ -1,23 +1,22 @@
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using CommandLine;
+using Common.Logging;
 using InEngine.Core;
 using InEngine.Core.Exceptions;
-using NLog;
 using InEngine.Core.IO;
-using System.Collections.Generic;
 
 namespace InEngine
 {
     public class ArgumentInterpreter
     {
-        public Logger Logger { get; set; }
+        public ILog Log { get; set; } = LogManager.GetLogger<PluginAssembly>();
         public string CliLogo { get; set; }
         public IWrite Write { get; set; } = new Write();
 
         public ArgumentInterpreter()
         {
-            Logger = LogManager.GetCurrentClassLogger();
             CliLogo = @"
   ___       _____             _              _   _ _____ _____ 
  |_ _|_ __ | ____|_ __   __ _(_)_ __   ___  | \ | | ____|_   _|
@@ -80,21 +79,21 @@ public void ExitWithSuccess(string message = null)
         {
             if (string.IsNullOrWhiteSpace(message))
                 message = "success";
-            Logger.Debug($"✔ {message}");
+            Log.Debug($"✔ {message}");
             Environment.Exit(ExitCodes.success);
         }
 
         public void ExitWithFailure(string message = null)
         {
-            Logger.Error(MakeErrorMessage(message));
+            Log.Error(MakeErrorMessage(message));
             Write.Error(message);
             Environment.Exit(ExitCodes.fail);
         }
 
         public void ExitWithFailure(Exception exception = null)
         {
             var ex = exception ?? new Exception("Unspecified failure");
-            Logger.Error(ex, MakeErrorMessage(ex.Message));
+            Log.Error(MakeErrorMessage(ex.Message), ex);
             Write.Error(ex.Message);
             Environment.Exit(ExitCodes.fail);
         }