Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Commit 77c8d7c

Browse files
author
John Cordeiro
authored
Merge pull request #2 from Ilhasoft/hotfix/0.6.2
Refactor of auto dismiss feature
2 parents 51e7cff + 373babb commit 77c8d7c

8 files changed

Lines changed: 25 additions & 25 deletions

File tree

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Step 2: Add the dependency
2525
```
2626
Latest Version: [![Latest version](https://jitpack.io/v/Ilhasoft/data-binding-validator.svg?style=flat-square)](https://jitpack.io/#Ilhasoft/data-binding-validator)
2727

28-
 
28+
2929
## Features:
3030

3131
* Minimum/Maximum length validation for text fields;
@@ -172,7 +172,7 @@ If you want to come back to the default way, call `validator.enableFieldValidati
172172

173173
### Auto dismiss ###
174174

175-
By default, the library auto dismiss the error messages when you start typing again, but it's configurable as well. You can add on your layout validation the same validation rule and adding `AutoDismiss` at the end, which receives a `boolean`. For example:
175+
By default, the library prompts error messages and doens't dismiss the error automatically, however, you can add on your layout validation the same rule name by adding `AutoDismiss` at the end, which receives a `boolean`. In this case it could dismiss the error automatically. For example:
176176

177177
```
178178
<EditText
@@ -182,5 +182,5 @@ By default, the library auto dismiss the error messages when you start typing ag
182182
android:hint="Name"
183183
app:validateDate='@{"dd/MM/yyyy"}'
184184
app:validateDateMessage="@{@string/dateErrorMessage}"
185-
app:validateDateAutoDismiss="@{false}" />
185+
app:validateDateAutoDismiss="@{true}" />
186186
```

library/build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,17 @@ android {
1414
defaultConfig {
1515
minSdkVersion 15
1616
targetSdkVersion 25
17-
versionCode 1
18-
versionName "0.5.0"
17+
versionCode 2
18+
versionName "0.6.2"
1919
consumerProguardFiles 'proguard-rules.pro'
2020
}
2121
}
2222

2323
dependencies {
2424
compile fileTree(dir: 'libs', include: ['*.jar'])
2525
testCompile 'junit:junit:4.12'
26-
compile 'com.android.support:appcompat-v7:25.1.1'
27-
compile 'com.android.support:design:25.1.1'
26+
compile 'com.android.support:appcompat-v7:25.3.0'
27+
compile 'com.android.support:design:25.3.0'
2828
}
2929

3030
// build a jar with source files

library/src/main/java/br/com/ilhasoft/support/validation/binding/DateBindings.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
public class DateBindings {
1616

1717
@BindingAdapter(value = {"validateDate", "validateDateMessage", "validateDateAutoDismiss"}, requireAll = false)
18-
public static void bindingDate(TextView view, String pattern, String errorMessage, Boolean autoDismiss) {
19-
if (autoDismiss == null || autoDismiss) {
18+
public static void bindingDate(TextView view, String pattern, String errorMessage, boolean autoDismiss) {
19+
if (autoDismiss) {
2020
EditTextHandler.disableErrorOnChanged(view);
2121
}
2222

library/src/main/java/br/com/ilhasoft/support/validation/binding/LengthBindings.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
public class LengthBindings {
1919

2020
@BindingAdapter(value = {"validateMinLength", "validateMinLengthMessage", "validateMinLengthAutoDismiss"}, requireAll = false)
21-
public static void bindingMinLength(TextView view, int minLength, String errorMessage, Boolean autoDismiss) {
22-
if (autoDismiss == null || autoDismiss) {
21+
public static void bindingMinLength(TextView view, int minLength, String errorMessage, boolean autoDismiss) {
22+
if (autoDismiss) {
2323
EditTextHandler.disableErrorOnChanged(view);
2424
}
2525

@@ -29,8 +29,8 @@ public static void bindingMinLength(TextView view, int minLength, String errorMe
2929
}
3030

3131
@BindingAdapter(value = {"validateMaxLength", "validateMaxLengthMessage", "validateMaxLengthAutoDismiss"}, requireAll = false)
32-
public static void bindingMaxLength(TextView view, int maxLength, String errorMessage, Boolean autoDismiss) {
33-
if (autoDismiss == null || autoDismiss) {
32+
public static void bindingMaxLength(TextView view, int maxLength, String errorMessage, boolean autoDismiss) {
33+
if (autoDismiss) {
3434
EditTextHandler.disableErrorOnChanged(view);
3535
}
3636

@@ -40,8 +40,8 @@ public static void bindingMaxLength(TextView view, int maxLength, String errorMe
4040
}
4141

4242
@BindingAdapter(value = {"validateEmpty", "validateEmptyMessage", "validateEmptyAutoDismiss"}, requireAll = false)
43-
public static void bindingEmpty(TextView view, boolean empty, String errorMessage, Boolean autoDismiss) {
44-
if (autoDismiss == null || autoDismiss) {
43+
public static void bindingEmpty(TextView view, boolean empty, String errorMessage, boolean autoDismiss) {
44+
if (autoDismiss) {
4545
EditTextHandler.disableErrorOnChanged(view);
4646
}
4747

library/src/main/java/br/com/ilhasoft/support/validation/binding/PasswordBindings.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
public class PasswordBindings {
1616

1717
@BindingAdapter(value = {"validatePassword", "validatePasswordMessage", "validatePasswordAutoDismiss"}, requireAll = false)
18-
public static void bindingPassword(TextView view, TextView comparableView, String errorMessage, Boolean autoDismiss) {
19-
if (autoDismiss == null || autoDismiss) {
18+
public static void bindingPassword(TextView view, TextView comparableView, String errorMessage, boolean autoDismiss) {
19+
if (autoDismiss) {
2020
EditTextHandler.disableErrorOnChanged(view);
2121
}
2222

library/src/main/java/br/com/ilhasoft/support/validation/binding/RegexBindings.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
public class RegexBindings {
1616

1717
@BindingAdapter(value = {"validateRegex", "validateRegexMessage", "validateRegexAutoDismiss"}, requireAll = false)
18-
public static void bindingRegex(TextView view, String pattern, String errorMessage, Boolean autoDismiss) {
19-
if (autoDismiss == null || autoDismiss) {
18+
public static void bindingRegex(TextView view, String pattern, String errorMessage, boolean autoDismiss) {
19+
if (autoDismiss) {
2020
EditTextHandler.disableErrorOnChanged(view);
2121
}
2222

library/src/main/java/br/com/ilhasoft/support/validation/binding/TypeBindings.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
public class TypeBindings {
1717

1818
@BindingAdapter(value = {"validateType", "validateTypeMessage", "validateTypeAutoDismiss"}, requireAll = false)
19-
public static void bindingTypeValidation(TextView view, String fieldTypeText, String errorMessage, Boolean autoDismiss) {
20-
if (autoDismiss == null || autoDismiss) {
19+
public static void bindingTypeValidation(TextView view, String fieldTypeText, String errorMessage, boolean autoDismiss) {
20+
if (autoDismiss) {
2121
EditTextHandler.disableErrorOnChanged(view);
2222
}
2323
TypeRule.FieldType fieldType = getFieldTypeByText(fieldTypeText);

sample/src/main/res/layout/activity_main.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
android:hint="Name"
2626
app:validateMinLength="@{4}"
2727
app:validateMinLengthMessage="@{@string/custom_error_min_length}"
28-
app:validateMinLengthAutoDismiss="@{false}"
28+
app:validateMinLengthAutoDismiss="@{true}"
2929
app:validateMaxLength="@{10}"
3030
app:validateMaxLengthMessage="@{@string/custom_error_max_length}"/>
3131

@@ -41,8 +41,7 @@
4141
android:layout_height="wrap_content"
4242
android:hint="Username"
4343
app:validateType='@{"username"}'
44-
app:validateTypeMessage="@{@string/custom_error_username}"
45-
app:validateTypeAutoDismiss="@{false}"/>
44+
app:validateTypeMessage="@{@string/custom_error_username}" />
4645

4746
</android.support.design.widget.TextInputLayout>
4847

@@ -54,7 +53,8 @@
5453
android:layout_width="match_parent"
5554
android:layout_height="wrap_content"
5655
android:hint="Email"
57-
app:validateType='@{"email"}' />
56+
app:validateType='@{"email"}'
57+
app:validateTypeAutoDismiss="@{true}"/>
5858

5959
</android.support.design.widget.TextInputLayout>
6060

0 commit comments

Comments
 (0)