Merge pull request #406 from melanger/patch-2

fix: name is optional in ORCID backend

Author: c00kiemon5ter

src/satosa/backends/orcid.py

@@ -73,7 +73,7 @@ def _authn_response(self, context):
             request_args=rargs, state=aresp['state'])
 
         user_info = self.user_information(
-            atresp['access_token'], atresp['orcid'], atresp['name'])
+            atresp['access_token'], atresp['orcid'], atresp.get('name'))
         internal_response = InternalData(
             auth_info=self.auth_info(context.request))
         internal_response.attributes = self.converter.to_internal(
@@ -82,7 +82,7 @@ def _authn_response(self, context):
         del context.state[self.name]
         return self.auth_callback_func(context, internal_response)
 
-    def user_information(self, access_token, orcid, name):
+    def user_information(self, access_token, orcid, name=None):
         base_url = self.config['server_info']['user_info']
         url = urljoin(base_url, '{}/person'.format(orcid))
         headers = {
@@ -92,13 +92,15 @@ def user_information(self, access_token, orcid, name):
         r = requests.get(url, headers=headers)
         r = r.json()
         emails, addresses = r['emails']['email'], r['addresses']['address']
+        rname = r.get('name') or {}
         ret = dict(
             address=', '.join([e['country']['value'] for e in addresses]),
             displayname=name,
             edupersontargetedid=orcid, orcid=orcid,
             mail=' '.join([e['email'] for e in emails]),
             name=name,
-            givenname=r['name']['given-names']['value'],
-            surname=(r['name']['family-name'] or {}).get('value'),
+            givenname=(rname.get('given-names') or {}).get('value'),
+            surname=(rname.get('family-name') or {}).get('value'),
         )
+
         return ret