Merge pull request #387 from REANNZ/fix_logging_remove_arg

c00kiemon5ter · web-flow · commit 779f12965fd8 · 2021-09-21T15:06:49.000+03:00
fix: do not pass extra arg to logging.error
diff --git a/src/satosa/base.py b/src/satosa/base.py
@@ -185,7 +185,7 @@ def _run_bound_endpoint(self, context, spec):
                 err_id=error.error_id, state=state
             )
             logline = lu.LOG_FMT.format(id=lu.get_session_id(context.state), message=msg)
-            logger.error(logline, error.state, exc_info=True)
+            logger.error(logline, exc_info=True)
             return self._handle_satosa_authentication_error(error)
 
     def _load_state(self, context):

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ def _run_bound_endpoint(self, context, spec):`
`185`	`185`	`err_id=error.error_id, state=state`
`186`	`186`	`)`
`187`	`187`	`logline = lu.LOG_FMT.format(id=lu.get_session_id(context.state), message=msg)`
`188`		`- logger.error(logline, error.state, exc_info=True)`
	`188`	`+ logger.error(logline, exc_info=True)`
`189`	`189`	`return self._handle_satosa_authentication_error(error)`
`190`	`190`
`191`	`191`	`def _load_state(self, context):`