Remove depricated route for getting published files

Author: rliebz

dataverse/dataset.py

@@ -146,32 +146,20 @@ def get_state(self, refresh=False):
         return self._state
 
     def get_file(self, file_name, published=False):
-        # Search published dataset if specified; otherwise, search draft
-        files = self.get_published_files() if published else self.get_files()
+        files = self.get_files(published)
         return next((f for f in files if f.name == file_name), None)
 
     def get_file_by_id(self, file_id, published=False):
-        # Search published dataset if specified; otherwise, search draft
-        files = self.get_published_files() if published else self.get_files()
+        files = self.get_files(published)
         return next((f for f in files if f.id == file_id), None)
 
     def get_files(self, published=False, refresh=True):
-        if published:
-            return self.get_published_files()
-
-        elements = get_elements(self.get_statement(refresh), 'entry')
+        if self.get_state(refresh) == 'DRAFT' and published:
+            return []
+        elements = get_elements(self.get_statement(), 'entry')
         return [DataverseFile.from_statement(element, self)
                 for element in elements]
 
-    def get_published_files(self):
-        metadata_url = 'https://{0}/dvn/api/metadata/{1}'.format(
-            self.connection.host, self.doi
-        )
-        xml = requests.get(metadata_url, auth=self.connection.auth).content
-        elements = get_elements(xml, tag='otherMat')
-        return [DataverseFile.from_metadata(element, self)
-                for element in elements]
-
     def add_file(self, filepath):
         self.add_files([filepath])
 

dataverse/file.py

@@ -20,7 +20,7 @@ def __init__(self, name, dataset, edit_media_uri=None, download_url=None):
         elif download_url:
             self.is_published = True
             self.download_url = download_url
-            self.id = download_url.split('=')[-1]
+            self.id = download_url.rsplit('=', 1)[-1]
         else:
             raise InsufficientMetadataError(
                 'Files must have an edit media uri or download url.'
@@ -29,7 +29,7 @@ def __init__(self, name, dataset, edit_media_uri=None, download_url=None):
     @classmethod
     def from_statement(cls, element, dataset):
         edit_media_uri = get_element(element, 'content').get('src')
-        name = edit_media_uri.rsplit("/")[-1]
+        name = edit_media_uri.rsplit("/", 1)[-1]
         return cls(name, dataset, edit_media_uri=edit_media_uri)
 
     @classmethod