fix: testcase and reset the form after submit

Author: ChengShi-1

docs/useCases.md

@@ -859,7 +859,7 @@ getDatasetDownloadCount
 
 _See [use case](../src/datasets/domain/useCases/GetDatasetDownloadCount.ts) implementation_.
 
-The `datasetId` parameter is a number for numeric identifiers.
+The `datasetId` parameter is a number for numeric identifiers or string for persistent identifiers.
 The `includeMDC` parameter is optional.
 
 - Setting `includeMDC` to True will ignore the `MDCStartDate` setting and return a total count.

src/datasets/domain/repositories/IDatasetsRepository.ts

@@ -53,6 +53,9 @@ export interface IDatasetsRepository {
     datasetVersionId: string,
     deaccessionDTO: DatasetDeaccessionDTO
   ): Promise<void>
-  getDatasetDownloadCount(datasetId: number, includeMDC?: boolean): Promise<DatasetDownloadCount>
+  getDatasetDownloadCount(
+    datasetId: number | string,
+    includeMDC?: boolean
+  ): Promise<DatasetDownloadCount>
   getDatasetVersionsSummaries(datasetId: number | string): Promise<DatasetVersionSummaryInfo[]>
 }

src/datasets/domain/useCases/GetDatasetDownloadCount.ts

@@ -12,11 +12,11 @@ export class GetDatasetDownloadCount implements UseCase<DatasetDownloadCount> {
   /**
    * Returns a DatasetDownloadCount instance, with dataset id, count and MDCStartDate(optional).
    *
-   * @param {number} [datasetId] - The dataset identifier.
+   * @param {number | string} [datasetId] - The dataset identifier.
    * @param {boolean} [includeMDC(optional)] - Indicates whether to consider include counts from MDC start date or not. The default value is false
    * @returns {Promise<DatasetDownloadCount>}
    */
-  async execute(datasetId: number, includeMDC?: boolean): Promise<DatasetDownloadCount> {
+  async execute(datasetId: number | string, includeMDC?: boolean): Promise<DatasetDownloadCount> {
     return await this.datasetsRepository.getDatasetDownloadCount(datasetId, includeMDC)
   }
 }

src/datasets/infra/repositories/DatasetsRepository.ts

@@ -239,13 +239,13 @@ export class DatasetsRepository extends ApiRepository implements IDatasetsReposi
   }
 
   public async getDatasetDownloadCount(
-    datasetId: number,
+    datasetId: number | string,
     includeMDC?: boolean
   ): Promise<DatasetDownloadCount> {
     const queryParams = includeMDC !== undefined ? { includeMDC } : {}
 
     return this.doGet(
-      this.buildApiEndpoint(this.datasetsResourceName, `${datasetId}/download/count`),
+      this.buildApiEndpoint(this.datasetsResourceName, `download/count`, datasetId),
       true,
       queryParams
     )

test/environment/docker-compose.yml

@@ -32,7 +32,7 @@ services:
         -Ddataverse.files.localstack1.access-key=default
         -Ddataverse.files.localstack1.secret-key=default
     ports:
-      - '8080:8080'
+      - '8081:8080'
     networks:
       - dataverse
     depends_on:

test/integration/datasets/DatasetsRepository.test.ts

@@ -1106,7 +1106,9 @@ describe('DatasetsRepository', () => {
       expect(actual[1].versionNumber).toBe('1.0')
       expect(actual[1].summary).toBe(DatasetVersionSummaryStringValues.firstPublished)
 
-      await deletePublishedDatasetViaApi(testDatasetIds.persistentId)
+      // await deletePublishedDatasetViaApi(testDatasetIds.persistentId)
+      console.log('od', testDatasetIds.numericId)
+      console.log('X-Dataverse-Key', process.env.TEST_API_KEY)
     })
   })
 

test/unit/datasets/DatasetsRepository.test.ts

@@ -1017,13 +1017,13 @@ describe('DatasetsRepository', () => {
     })
   })
 
-  describe('getDatasetDownloaCount', () => {
+  describe('getDatasetDownloadCount', () => {
     const testDatasetDownloadCount: DatasetDownloadCount = {
       id: testDatasetModel.id,
       downloadCount: 1,
       MDCStartDate: '2021-01-01'
     }
-    test('should return citation when response is successful', async () => {
+    test('should return download count when response is successful', async () => {
       jest.spyOn(axios, 'get').mockResolvedValue({ data: testDatasetDownloadCount })
 
       const actual = await sut.getDatasetDownloadCount(testDatasetModel.id)