fix: tests and createGuestbookDTO

Author: ChengShi-1

docs/useCases.md

@@ -2866,9 +2866,6 @@ const guestbook: CreateGuestbookDTO = {
   nameRequired: true,
   institutionRequired: false,
   positionRequired: false,
-  email: 'test@gmail.com',
-  institution: 'Harvard University',
-  position: 'Researcher',
   customQuestions: [
     {
       question: 'Describe yourself',
@@ -2898,6 +2895,7 @@ import { setGuestbookEnabled } from '@iqss/dataverse-client-javascript'
 
 const collectionIdOrAlias = 'root'
 const guestbookId = 123
+const enabled = false
 
 setGuestbookEnabled.execute(collectionIdOrAlias, guestbookId, false).then(() => {
   /* ... */

src/access/domain/dtos/GuestbookResponseDTO.ts

@@ -9,6 +9,6 @@ export interface GuestbookResponseDTO {
     email?: string
     institution?: string
     position?: string
-    answers: GuestbookAnswerDTO[]
+    answers?: GuestbookAnswerDTO[]
   }
 }

src/access/infra/repositories/AccessRepository.ts

@@ -21,7 +21,7 @@ export class AccessRepository extends ApiRepository implements IAccessRepository
   }
 
   public async submitGuestbookForDatafilesDownload(
-    fileIds: string | Array<number | string>,
+    fileIds: Array<number>,
     guestbookResponse: GuestbookResponseDTO
   ): Promise<string> {
     return this.doPost(

src/guestbooks/domain/dtos/CreateGuestbookDTO.ts

@@ -21,8 +21,5 @@ export interface CreateGuestbookDTO {
   nameRequired: boolean
   institutionRequired: boolean
   positionRequired: boolean
-  email: string
-  institution: string
-  position: string
   customQuestions: CreateGuestbookCustomQuestionDTO[]
 }

src/guestbooks/domain/models/Guestbook.ts

@@ -22,9 +22,6 @@ export interface Guestbook {
   nameRequired: boolean
   institutionRequired: boolean
   positionRequired: boolean
-  email: string
-  institution: string
-  position: string
   customQuestions: GuestbookCustomQuestion[]
   createTime: string
   dataverseId: number

test/integration/access/AccessRepository.test.ts

@@ -67,6 +67,7 @@ describe('AccessRepository', () => {
       const actual = await sut.submitGuestbookForDatafileDownload(testFileId, guestbookResponse)
 
       expect(actual).toEqual(expect.any(String))
+      expect(() => new URL(actual)).not.toThrow()
     })
 
     test('should return error when datafile does not exist', async () => {
@@ -93,6 +94,7 @@ describe('AccessRepository', () => {
         guestbookResponse
       )
       expect(actual).toEqual(expect.any(String))
+      expect(() => new URL(actual)).not.toThrow()
     })
 
     test('should return error when dataset does not exist', async () => {
@@ -111,6 +113,7 @@ describe('AccessRepository', () => {
         guestbookResponse
       )
       expect(actual).toEqual(expect.any(String))
+      expect(() => new URL(actual)).not.toThrow()
     })
 
     test('should return error when dataset version does not exist', async () => {

test/integration/guestbooks/GuestbooksRepository.test.ts

@@ -29,9 +29,6 @@ describe('GuestbooksRepository', () => {
     nameRequired: true,
     institutionRequired: false,
     positionRequired: false,
-    email: 'test@gmail.com',
-    institution: 'Harvard University',
-    position: 'Researcher',
     customQuestions: [
       {
         question: "how's your day",

test/unit/guestbooks/CreateGuestbook.test.ts

@@ -11,9 +11,6 @@ describe('CreateGuestbook', () => {
     nameRequired: true,
     institutionRequired: false,
     positionRequired: false,
-    email: 'test@gmail.com',
-    institution: 'Harvard University',
-    position: 'Researcher',
     customQuestions: [
       {
         question: "how's your day",