test: add unit and integration test

Author: g-saracca

test/integration/collections/CollectionsRepository.test.ts

@@ -804,6 +804,63 @@ describe('CollectionsRepository', () => {
     })
   })
 
+  describe('getCollectionsForLinking', () => {
+    const linkingTargetAlias = 'collectionsRepositoryLinkTarget'
+
+    beforeAll(async () => {
+      await createCollectionViaApi(linkingTargetAlias)
+    })
+
+    afterAll(async () => {
+      await deleteCollectionViaApi(linkingTargetAlias)
+    })
+
+    test('should list collections for linking for a given collection alias', async () => {
+      const results = await sut.getCollectionsForLinking(
+        'collection',
+        testCollectionAlias,
+        'Scientific'
+      )
+
+      expect(Array.isArray(results)).toBe(true)
+      // Should contain the newly created linking target collection among candidates
+      const found = results.find((c) => c.alias === linkingTargetAlias)
+      expect(found).toBeDefined()
+      expect(found?.id).toBeGreaterThan(0)
+      expect(found?.displayName).toBe('Scientific Research')
+    })
+
+    test('should list collections for linking for a given dataset persistentId', async () => {
+      // Create a temporary dataset to query linking candidates
+      const { persistentId, numericId } = await createDataset.execute(
+        TestConstants.TEST_NEW_DATASET_DTO,
+        testCollectionAlias
+      )
+
+      const results = await sut.getCollectionsForLinking('dataset', persistentId, 'Scientific')
+
+      // Cleanup dataset (unpublished)
+      await deleteUnpublishedDatasetViaApi(numericId)
+
+      expect(Array.isArray(results)).toBe(true)
+      const found = results.find((c) => c.alias === linkingTargetAlias)
+      expect(found).toBeDefined()
+      expect(found?.displayName).toBe('Scientific Research')
+    })
+
+    it('should return error when collection does not exist', async () => {
+      await expect(
+        sut.getCollectionsForLinking('collection', TestConstants.TEST_DUMMY_COLLECTION_ALIAS, '')
+      ).rejects.toThrow(ReadError)
+    })
+
+    it('should return error when dataset does not exist', async () => {
+      await expect(
+        sut.getCollectionsForLinking('dataset', TestConstants.TEST_DUMMY_PERSISTENT_ID, '')
+      ).rejects.toThrow(ReadError)
+    })
+  })
+
   describe('getCollectionItems for published tabular file', () => {
     let testDatasetIds: CreatedDatasetIdentifiers
     const testTextFile4Name = 'test-file-4.tab'

test/unit/collections/CollectionsRepository.test.ts

@@ -567,6 +567,55 @@ describe('CollectionsRepository', () => {
     })
   })
 
+  describe('getCollectionsForLinking', () => {
+    test('should call dataverse variant with numeric id and search term', async () => {
+      const payload = {
+        data: {
+          status: 'OK',
+          data: [
+            { id: 1, alias: 'dv1', name: 'DV 1' },
+            { id: 2, alias: 'dv2', name: 'DV 2' }
+          ]
+        }
+      }
+      jest.spyOn(axios, 'get').mockResolvedValue(payload)
+
+      const actual = await sut.getCollectionsForLinking('collection', 99, 'abc')
+      const expectedEndpoint = `${TestConstants.TEST_API_URL}/dataverses/99/dataverse/linkingDataverses`
+      const expectedParams = new URLSearchParams({ searchTerm: 'abc' })
+      const expectedConfig = {
+        params: expectedParams,
+        headers: TestConstants.TEST_EXPECTED_AUTHENTICATED_REQUEST_CONFIG_API_KEY.headers
+      }
+      expect(axios.get).toHaveBeenCalledWith(expectedEndpoint, expectedConfig)
+      expect(actual).toEqual([
+        { id: 1, alias: 'dv1', displayName: 'DV 1' },
+        { id: 2, alias: 'dv2', displayName: 'DV 2' }
+      ])
+    })
+
+    test('should call dataset variant using persistentId and map results', async () => {
+      const payload = {
+        data: {
+          status: 'OK',
+          data: [{ id: 3, alias: 'dv3', name: 'DV 3' }]
+        }
+      }
+      jest.spyOn(axios, 'get').mockResolvedValue(payload)
+
+      const pid = 'doi:10.5072/FK2/J8SJZB'
+      const actual = await sut.getCollectionsForLinking('dataset', pid, '')
+      const expectedEndpoint = `${TestConstants.TEST_API_URL}/dataverses/:persistentId/dataset/linkingDataverses`
+      const expectedParams = new URLSearchParams({ persistentId: pid })
+      const expectedConfig = {
+        params: expectedParams,
+        headers: TestConstants.TEST_EXPECTED_AUTHENTICATED_REQUEST_CONFIG_API_KEY.headers
+      }
+      expect(axios.get).toHaveBeenCalledWith(expectedEndpoint, expectedConfig)
+      expect(actual).toEqual([{ id: 3, alias: 'dv3', displayName: 'DV 3' }])
+    })
+  })
+
   describe('deleteCollection', () => {
     const deleteTestCollectionAlias = 'deleteCollection-unit-test'
     const deleteTestCollectionId = 123

test/unit/collections/GetCollectionsForLinking.test.ts

@@ -0,0 +1,28 @@
+import { ICollectionsRepository } from '../../../src/collections/domain/repositories/ICollectionsRepository'
+import { GetCollectionsForLinking } from '../../../src/collections/domain/useCases/GetCollectionsForLinking'
+import { CollectionSummary, ReadError } from '../../../src'
+
+const sample: CollectionSummary[] = [
+  { id: 1, alias: 'col1', displayName: 'Collection 1' },
+  { id: 2, alias: 'col2', displayName: 'Collection 2' }
+]
+
+describe('GetCollectionsForLinking', () => {
+  test('should return collections for linking on success', async () => {
+    const repo: ICollectionsRepository = {} as ICollectionsRepository
+    repo.getCollectionsForLinking = jest.fn().mockResolvedValue(sample)
+
+    const uc = new GetCollectionsForLinking(repo)
+    await expect(uc.execute('collection', 123, 'foo')).resolves.toEqual(sample)
+    expect(repo.getCollectionsForLinking).toHaveBeenCalledWith('collection', 123, 'foo')
+  })
+
+  test('should return error result on repository error', async () => {
+    const repo: ICollectionsRepository = {} as ICollectionsRepository
+    repo.getCollectionsForLinking = jest.fn().mockRejectedValue(new ReadError('x'))
+
+    const uc = new GetCollectionsForLinking(repo)
+    await expect(uc.execute('dataset', 'doi:10.123/ABC')).rejects.toThrow(ReadError)
+    expect(repo.getCollectionsForLinking).toHaveBeenCalledWith('dataset', 'doi:10.123/ABC', '')
+  })
+})