Skip to content

Commit 4f24d91

Browse files
committed
test: avoid asserting complete url with origin and port
1 parent 07d639f commit 4f24d91

3 files changed

Lines changed: 14 additions & 14 deletions

File tree

test/functional/collections/GetCollectionFeaturedItems.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ describe('execute', () => {
8989
expect(featuredItemOne.id).toBe(testFeaturedItemIds[0])
9090
expect(featuredItemOne.displayOrder).toBe(1)
9191
expect(featuredItemOne.content).toBe('<p class="rte-paragraph">Test content</p>')
92-
expect(featuredItemOne.imageFileUrl).toBe(
93-
`http://localhost:8080/api/access/dataverseFeaturedItemImage/${featuredItemOne.id}`
92+
expect(featuredItemOne.imageFileUrl).toContain(
93+
`/api/access/dataverseFeaturedItemImage/${featuredItemOne.id}`
9494
)
9595
expect(featuredItemOne.imageFileName).toBe('featured-item-test-image.png')
9696

test/functional/collections/UpdateCollectionFeaturedItems.test.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,8 @@ describe('execute', () => {
168168
expect(thirdItemResponse.content).toEqual(EXPECTED_CONTENT_FIELD_WITH_ALL_TAGS)
169169
expect(thirdItemResponse.displayOrder).toBe(newFeaturedItems[2].displayOrder)
170170
expect(thirdItemResponse.imageFileName).toEqual('featured-item-test-image-3.png')
171-
expect(thirdItemResponse.imageFileUrl).toBe(
172-
`http://localhost:8080/api/access/dataverseFeaturedItemImage/${updatedFeaturedItemsResponse[2].id}`
171+
expect(thirdItemResponse.imageFileUrl).toContain(
172+
`/api/access/dataverseFeaturedItemImage/${updatedFeaturedItemsResponse[2].id}`
173173
)
174174

175175
expect(fourthItemResponse.type).toBe(FeaturedItemType.COLLECTION)
@@ -315,8 +315,8 @@ describe('execute', () => {
315315
expect(updatedFeaturedItem.displayOrder).toBe(newFeaturedItems[0].displayOrder)
316316
// Should keep the existing file even if a file was not provided because keepFile is true
317317
expect(updatedFeaturedItem.imageFileName).toEqual(testFeaturedItemFilename)
318-
expect(updatedFeaturedItem.imageFileUrl).toBe(
319-
`http://localhost:8080/api/access/dataverseFeaturedItemImage/${updatedFeaturedItem.id}`
318+
expect(updatedFeaturedItem.imageFileUrl).toContain(
319+
`/api/access/dataverseFeaturedItemImage/${updatedFeaturedItem.id}`
320320
)
321321
})
322322

@@ -371,8 +371,8 @@ describe('execute', () => {
371371
expect(updatedFeaturedItem.content).toBe((newFeaturedItems[0] as CustomFeaturedItem).content)
372372
expect(updatedFeaturedItem.displayOrder).toBe(newFeaturedItems[0].displayOrder)
373373
expect(updatedFeaturedItem.imageFileName).toEqual('featured-item-test-image-updated.png')
374-
expect(updatedFeaturedItem.imageFileUrl).toBe(
375-
`http://localhost:8080/api/access/dataverseFeaturedItemImage/${updatedFeaturedItem.id}`
374+
expect(updatedFeaturedItem.imageFileUrl).toContain(
375+
`/api/access/dataverseFeaturedItemImage/${updatedFeaturedItem.id}`
376376
)
377377
})
378378

@@ -401,8 +401,8 @@ describe('execute', () => {
401401
expect(testFeaturedItem.displayOrder).toBe(newFeaturedItems[0].displayOrder)
402402
// Should keep the existing file even if a file was provided because keepFile is true
403403
expect(testFeaturedItem.imageFileName).toEqual(testFeaturedItemFilename)
404-
expect(testFeaturedItem.imageFileUrl).toBe(
405-
`http://localhost:8080/api/access/dataverseFeaturedItemImage/${updatedFeaturedItemsResponse[0].id}`
404+
expect(testFeaturedItem.imageFileUrl).toContain(
405+
`/api/access/dataverseFeaturedItemImage/${updatedFeaturedItemsResponse[0].id}`
406406
)
407407
})
408408
})

test/integration/collections/CollectionsRepository.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1177,8 +1177,8 @@ describe('CollectionsRepository', () => {
11771177
expect(firstFeaturedItem.id).toBe(testFeaturedItemId)
11781178
expect(firstFeaturedItem.displayOrder).toBe(1)
11791179
expect(firstFeaturedItem.content).toBe('<p class="rte-paragraph">Test content</p>')
1180-
expect(firstFeaturedItem.imageFileUrl).toBe(
1181-
`http://localhost:8080/api/access/dataverseFeaturedItemImage/${firstFeaturedItem.id}`
1180+
expect(firstFeaturedItem.imageFileUrl).toContain(
1181+
`/api/access/dataverseFeaturedItemImage/${firstFeaturedItem.id}`
11821182
)
11831183
expect(firstFeaturedItem.imageFileName).toBe('featured-item-test-image.png')
11841184
})
@@ -1257,8 +1257,8 @@ describe('CollectionsRepository', () => {
12571257
expect(thirdFeaturedItem.content).toEqual((newFeaturedItems[2] as CustomFeaturedItem).content)
12581258
expect(thirdFeaturedItem.displayOrder).toEqual(newFeaturedItems[2].displayOrder)
12591259
expect(thirdFeaturedItem.imageFileName).toEqual('featured-item-test-image-3.png')
1260-
expect(thirdFeaturedItem.imageFileUrl).toBe(
1261-
`http://localhost:8080/api/access/dataverseFeaturedItemImage/${response[2].id}`
1260+
expect(thirdFeaturedItem.imageFileUrl).toContain(
1261+
`/api/access/dataverseFeaturedItemImage/${response[2].id}`
12621262
)
12631263
})
12641264

0 commit comments

Comments
 (0)