update the signer

Author: bretkikehara

cmd/server/main.go

@@ -28,10 +28,6 @@ func main() {
 	logger.SetLevel(parsedLogLevel)
 	logger.Infof("Log Level: %s, parsed as iota %v", *logLevel, parsedLogLevel)
 
-	if *origin == "" {
-		logger.Fatalf("Origin ads.cert Call Sign domain name is required")
-	}
-
 	if *privateKey == "" {
 		logger.Fatalf("Private key is required")
 	}

examples/signer-client/signer-client.go

@@ -16,6 +16,7 @@ import (
 
 var (
 	serverAddress  = flag.String("server_address", "localhost:3000", "address of grpc server")
+	originDomain   = flag.String("origin_domain", "", "Origin domain")
 	destinationURL = flag.String("url", "https://google.com/gen_204", "URL to invoke")
 	body           = flag.String("body", "", "POST request body")
 	signingTimeout = flag.Duration("signing_timeout", 5*time.Millisecond, "Specifies how long this client will wait for signing to finish before abandoning.")
@@ -49,6 +50,9 @@ func main() {
 	// destination URL and body, setting these value on the RequestInfo message.
 	reqInfo := &api.RequestInfo{}
 	signatory.SetRequestInfo(reqInfo, *destinationURL, []byte(*body))
+	if originDomain != nil {
+		reqInfo.OriginDomain = *originDomain
+	}
 
 	// Request the signature.
 	logger.Infof("signing request for url: %v", *destinationURL)

internal/formats/adscert_connection_signature.go

@@ -132,22 +132,21 @@ func EncodeSignatureSuffix(
 }
 
 func NewAuthenticatedConnectionSignature(status AuthenticatedConnectionProtocolStatus, from string, invoking string) (*AuthenticatedConnectionSignature, error) {
+	s := &AuthenticatedConnectionSignature{}
+	s.status = status
+	s.from = from
+	s.invoking = invoking
 
 	if status == StatusUnspecified {
-		return nil, ErrParamMissingStatus
+		return s, ErrParamMissingStatus
 	}
 	if from == "" {
-		return nil, ErrParamMissingFrom
+		return s, ErrParamMissingFrom
 	}
 	if invoking == "" {
-		return nil, ErrParamMissingInvoking
+		return s, ErrParamMissingInvoking
 	}
 
-	s := &AuthenticatedConnectionSignature{}
-	s.status = status
-	s.from = from
-	s.invoking = invoking
-
 	return s, nil
 }