fix(#161): address PR #164 review feedback

LeeCampbell · claude · LeeCampbell · commit ca3c7937dc9d · 2026-03-27T20:58:35.000+08:00
- Remove unused `using System;` from Bitwise.cs
- Convert BitwiseTests to FluentAssertions for consistency
- Add negative value test case (-1L, expected: 0)
- Fix build-system.md spec to match actual csproj (bin\Release\...)

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/HdrHistogram.UnitTests/Utilities/BitwiseTests.cs b/HdrHistogram.UnitTests/Utilities/BitwiseTests.cs
@@ -6,6 +6,7 @@
  * http://creativecommons.org/publicdomain/zero/1.0/
  */
 
+using FluentAssertions;
 using HdrHistogram.Utilities;
 using Xunit;
 
@@ -37,9 +38,10 @@ public class BitwiseTests
         [InlineData(1L << 32, 31)]
         [InlineData(1L << 62, 1)]
         [InlineData(long.MaxValue, 1)]
+        [InlineData(-1L, 0)]
         public void NumberOfLeadingZeros_ReturnsCorrectValue(long value, int expected)
         {
-            Assert.Equal(expected, Bitwise.NumberOfLeadingZeros(value));
+            Bitwise.NumberOfLeadingZeros(value).Should().Be(expected);
         }
     }
 }
diff --git a/HdrHistogram/Utilities/Bitwise.cs b/HdrHistogram/Utilities/Bitwise.cs
@@ -6,8 +6,6 @@
  * http://creativecommons.org/publicdomain/zero/1.0/
  */
 
-using System;
-
 namespace HdrHistogram.Utilities
 {
     /// <summary>
diff --git a/spec/tech-standards/build-system.md b/spec/tech-standards/build-system.md
@@ -86,7 +86,7 @@ XML documentation is generated for Release builds:
 
 ```xml
 <PropertyGroup Condition="'$(Configuration)' == 'Release'">
-  <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\HdrHistogram.xml</DocumentationFile>
+  <DocumentationFile>bin\Release\$(TargetFramework)\HdrHistogram.xml</DocumentationFile>
 </PropertyGroup>
 ```
 

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`	`* http://creativecommons.org/publicdomain/zero/1.0/`
`7`	`7`	`*/`
`8`	`8`
	`9`	`+using FluentAssertions;`
`9`	`10`	`using HdrHistogram.Utilities;`
`10`	`11`	`using Xunit;`
`11`	`12`
`@@ -37,9 +38,10 @@ public class BitwiseTests`
`37`	`38`	`[InlineData(1L << 32, 31)]`
`38`	`39`	`[InlineData(1L << 62, 1)]`
`39`	`40`	`[InlineData(long.MaxValue, 1)]`
	`41`	`+ [InlineData(-1L, 0)]`
`40`	`42`	`public void NumberOfLeadingZeros_ReturnsCorrectValue(long value, int expected)`
`41`	`43`	`{`
`42`		`- Assert.Equal(expected, Bitwise.NumberOfLeadingZeros(value));`
	`44`	`+ Bitwise.NumberOfLeadingZeros(value).Should().Be(expected);`
`43`	`45`	`}`
`44`	`46`	`}`
`45`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,6 @@`
`6`	`6`	`* http://creativecommons.org/publicdomain/zero/1.0/`
`7`	`7`	`*/`
`8`	`8`
`9`		`-using System;`
`10`		`-`
`11`	`9`	`namespace HdrHistogram.Utilities`
`12`	`10`	`{`
`13`	`11`	`/// <summary>`