feat(#131): Fix build warnings from dotnet build Release configuration (#137)

* plan(#131): initial brief from issue

* plan(#131): review brief

* plan(#131): apply brief review feedback

* plan(#131): review brief

* plan(#131): apply brief review feedback

* plan(#131): review brief

* plan(#131): apply brief review feedback

* plan(#131): review brief

* plan(#131): create task breakdown

* feat(#131): implement tasks

* feat(#131): complete implementation

* fix(#131): use char overload of StartsWith on net8.0 to resolve CA1865

Use preprocessor directive to select string.StartsWith(char) on net8.0
and string.StartsWith(string, StringComparison) on netstandard2.0,
satisfying both CA1865 and CA1310 analyser rules.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(#131): remove redundant HistogramIterationValue allocation in enumerator

Current property now points directly to _currentIterationValue field,
eliminating a dead allocation and the misleading indirection where
MoveNext() reassigned Current to the same object that _currentIterationValue
already referenced.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Lee Campbell <lee.ryan.campbell@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: 3 people

HdrHistogram/HistogramBase.cs

@@ -47,7 +47,7 @@ public abstract class HistogramBase : IRecorder
         private readonly int _bucketIndexOffset;
         private long _maxValue;
         private long _minNonZeroValue;
-        private string _tag;
+        private string? _tag;
 
         /// <summary>
         /// An identifier for the Histogram. Maybe generated by the Recorder if used.
@@ -87,7 +87,7 @@ public abstract class HistogramBase : IRecorder
         /// <summary>
         /// Gets or Sets the optional Tag string associated with this histogram.
         /// </summary>
-        public string Tag
+        public string? Tag
         {
             get { return _tag; }
             set
@@ -704,7 +704,7 @@ private long ValueFromIndex(int index)
             return ValueFromIndex(bucketIndex, subBucketIndex);
         }
 
-        private IRecordedData GetData()
+        private RecordedData GetData()
         {
             var relevantCounts = GetRelevantCounts();
             return new RecordedData(

HdrHistogram/HistogramEncoding.cs

@@ -62,7 +62,7 @@ public static HistogramBase DecodeFromCompressedByteBuffer(ByteBuffer buffer, lo
         /// <param name="decompressor">The <see cref="DeflateStream"/> that is being used to decompress the payload. Optional.</param>
         /// <returns>The newly constructed histogram</returns>
         public static HistogramBase DecodeFromByteBuffer(ByteBuffer buffer, long minBarForHighestTrackableValue,
-           DeflateStream decompressor = null)
+           DeflateStream? decompressor = null)
         {
             var header = ReadHeader(buffer);
             var wordSizeInBytes = GetWordSizeInBytesFromCookie(header.Cookie);
@@ -165,7 +165,7 @@ private static HistogramBase Create(Type histogramType, IHeader header, long min
             }
         }
 
-        private static ByteBuffer PayLoadSourceBuffer(ByteBuffer buffer, DeflateStream decompressor, int expectedCapacity, IHeader header)
+        private static ByteBuffer PayLoadSourceBuffer(ByteBuffer buffer, DeflateStream? decompressor, int expectedCapacity, IHeader header)
         {
             ByteBuffer payLoadSourceBuffer;
             if (decompressor == null)
@@ -239,7 +239,7 @@ private static Type GetBestTypeForWordSize(int wordSizeInBytes)
                 case 8: return typeof(LongHistogram);
                 case 9: return typeof(LongHistogram);
                 default:
-                    throw new IndexOutOfRangeException();
+                    throw new InvalidOperationException($"Unexpected word size: {wordSizeInBytes}");
             }
         }
     }

HdrHistogram/HistogramFactoryDelegate.cs

@@ -15,6 +15,8 @@ namespace HdrHistogram
     /// The number of significant decimal digits to which the histogram will maintain value resolution and separation. 
     /// Must be a non-negative integer between 0 and 5.
     /// </param>
+#pragma warning disable CA1711
     public delegate HistogramBase HistogramFactoryDelegate(
         long instanceId, long lowestDiscernibleValue, long highestTrackableValue, int numberOfSignificantValueDigits);
+#pragma warning restore CA1711
 }

HdrHistogram/HistogramLogReader.cs

@@ -1,6 +1,7 @@
 using HdrHistogram.Utilities;
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Text.RegularExpressions;
@@ -239,31 +240,35 @@ private IEnumerable<string> ReadLines()
 
         private static bool IsComment(string line)
         {
-            return line.StartsWith("#");
+#if NETSTANDARD2_0
+            return line.StartsWith("#", StringComparison.Ordinal);
+#else
+            return line.StartsWith('#');
+#endif
         }
 
         private static bool IsStartTime(string line)
         {
-            return line.StartsWith("#[StartTime: ");
+            return line.StartsWith("#[StartTime: ", StringComparison.Ordinal);
         }
 
         private static bool IsBaseTime(string line)
         {
-            return line.StartsWith("#[BaseTime: ");
+            return line.StartsWith("#[BaseTime: ", StringComparison.Ordinal);
         }
 
         private static bool IsLegend(string line)
         {
             var legend = "\"StartTimestamp\",\"Interval_Length\",\"Interval_Max\",\"Interval_Compressed_Histogram\"";
-            return line.Equals(legend);
+            return string.Equals(line, legend, StringComparison.Ordinal);
         }
         private static bool IsV1Legend(string line)
         {
             var legend = "\"StartTimestamp\",\"EndTimestamp\",\"Interval_Max\",\"Interval_Compressed_Histogram\"";
-            return line.Equals(legend);
+            return string.Equals(line, legend, StringComparison.Ordinal);
         }
 
-        private static string ParseTag(string value)
+        private static string? ParseTag(string value)
         {
             if (string.IsNullOrWhiteSpace(value))
                 return null;
@@ -288,7 +293,7 @@ private static double ParseBaseTime(string line)
         private static double ParseDouble(Match match, string group)
         {
             var value = match.Groups[group].Value;
-            return double.Parse(value);
+            return double.Parse(value, CultureInfo.InvariantCulture);
         }
 
         /// <summary>

HdrHistogram/HistogramLogWriter.cs

@@ -14,8 +14,8 @@ public sealed class HistogramLogWriter : IDisposable
         private const string HistogramLogFormatVersion = "1.3";
 
         private readonly TextWriter _log;
-        private bool _hasHeaderWritten = false;
-        private int _isDisposed = 0;
+        private bool _hasHeaderWritten;
+        private int _isDisposed;
 
         /// <summary>
         /// Writes the provided histograms to the underlying <see cref="Stream"/> with a given overall start time.

HdrHistogram/IntConcurrentHistogram.cs

@@ -21,7 +21,7 @@ public class IntConcurrentHistogram : HistogramBase
     {
         private readonly WriterReaderPhaser _wrp = new WriterReaderPhaser();
         private readonly AtomicIntArray _counts;
-        private long _totalCount = 0L;
+        private long _totalCount;
 
         /// <summary>
         /// Construct a <see cref="IntConcurrentHistogram"/> given the lowest and highest values to be tracked and a number of significant decimal digits.

HdrHistogram/Iteration/AbstractHistogramEnumerator.cs

@@ -35,7 +35,7 @@ internal abstract class AbstractHistogramEnumerator : IEnumerator<HistogramItera
         protected long TotalCountToCurrentIndex { get; private set; }
         protected long CountAtThisValue { get; private set; }
 
-        public HistogramIterationValue Current { get; private set; }
+        public HistogramIterationValue Current => _currentIterationValue;
 
         protected AbstractHistogramEnumerator(HistogramBase histogram)
         {
@@ -160,7 +160,7 @@ bool IEnumerator.MoveNext()
             var canMove = HasNext();
             if (canMove)
             {
-                Current = Next();
+                Next();
             }
             return canMove;
         }

HdrHistogram/LongConcurrentHistogram.cs

@@ -21,7 +21,7 @@ public class LongConcurrentHistogram : HistogramBase
     {
         private readonly WriterReaderPhaser _wrp = new WriterReaderPhaser();
         private readonly AtomicLongArray _counts;
-        private long _totalCount = 0L;
+        private long _totalCount;
 
 
         /// <summary>

HdrHistogram/Persistence/CountsDecoder.cs

@@ -8,7 +8,7 @@ namespace HdrHistogram.Persistence
     /// </summary>
     public static class CountsDecoder
     {
-        private static readonly IDictionary<int, ICountsDecoder> Decoders;
+        private static readonly Dictionary<int, ICountsDecoder> Decoders;
 
         static CountsDecoder()
         {

HdrHistogram/Recorder.cs

@@ -30,7 +30,7 @@ public class Recorder : IRecorder
         private readonly HistogramFactoryDelegate _histogramFactory;
 
         private HistogramBase _activeHistogram;
-        private HistogramBase _inactiveHistogram;
+        private HistogramBase? _inactiveHistogram;
 
         /// <summary>
         /// Creates a recorder that will delegate recording to histograms created from these parameters.
@@ -147,7 +147,7 @@ public HistogramBase GetIntervalHistogram()
         /// NOTE: The caller is responsible for not recycling the same returned interval histogram more than once. 
         /// If the same interval histogram instance is recycled more than once, behavior is undefined.
         /// </remarks>
-        public HistogramBase GetIntervalHistogram(HistogramBase histogramToRecycle)
+        public HistogramBase GetIntervalHistogram(HistogramBase? histogramToRecycle)
         {
             lock (_gate)
             {
@@ -157,7 +157,7 @@ public HistogramBase GetIntervalHistogram(HistogramBase histogramToRecycle)
                 PerformIntervalSample();
                 var sampledHistogram = _inactiveHistogram;
                 _inactiveHistogram = null; // Once we expose the sample, we can't reuse it internally until it is recycled
-                return sampledHistogram;
+                return sampledHistogram!;
             }
         }
 
@@ -172,7 +172,7 @@ public void GetIntervalHistogramInto(HistogramBase targetHistogram)
             lock (_gate)
             {
                 PerformIntervalSample();
-                _inactiveHistogram.CopyInto(targetHistogram);
+                _inactiveHistogram!.CopyInto(targetHistogram);
             }
         }
 
@@ -227,7 +227,7 @@ private void PerformIntervalSample()
             }
         }
 
-        private void ValidateFitAsReplacementHistogram(HistogramBase replacementHistogram)
+        private void ValidateFitAsReplacementHistogram(HistogramBase? replacementHistogram)
         {
             if (replacementHistogram != null && replacementHistogram.InstanceId != _activeHistogram.InstanceId)
             {