Skip to content

Commit 85c8788

Browse files
LeeCampbellclaude
andauthored
fix: align benchmark runtimes with project target frameworks (#157)
* fix: align benchmark runtimes with project target frameworks Replace obsolete benchmark job configuration (Net481, Core 2.1–7.0) with the actual target frameworks: net8.0, net9.0, and net10.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: drop manual runtime jobs to avoid BenchmarkDotNet net10.0 crash BenchmarkDotNet 0.15.8 does not recognise the net10.0 moniker via CreateForNewVersion, throwing NotImplementedException. Remove the manual job/column config and use DefaultConfig instead. Specific runtimes can be targeted via CLI args (--runtimes net8.0 net9.0). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: restore benchmark columns and multi-runtime config Restore the original percentile/statistics columns and multi-runtime job configuration. Keep net8.0 and net9.0 runtimes (net10.0 is not yet supported by BenchmarkDotNet 0.15.8). Update build.cmd to pass --runtimes net8.0 net9.0 so both configured runtimes are exercised. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: use CoreRuntime.Core10_0 for net10.0 benchmark job BenchmarkDotNet 0.15.8 supports net10.0 via CoreRuntime.Core10_0, not CreateForNewVersion. Revert build.cmd to original form without --runtimes flag as the jobs are configured in code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 7573f30 commit 85c8788

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

HdrHistogram.Benchmarking/Program.cs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,13 @@ class Program
1111
static void Main(string[] args)
1212
{
1313
var config = ManualConfig.Create(DefaultConfig.Instance)
14-
//.AddDiagnoser(MemoryDiagnoser.Default)
1514
.AddColumn(
1615
StatisticColumn.OperationsPerSecond,
1716
StatisticColumn.Mean, StatisticColumn.StdErr, StatisticColumn.StdDev,
1817
StatisticColumn.P0, StatisticColumn.Q1, StatisticColumn.P50, StatisticColumn.P67, StatisticColumn.Q3, StatisticColumn.P80, StatisticColumn.P90, StatisticColumn.P95, StatisticColumn.P100)
19-
.AddJob(Job.Default.WithRuntime(ClrRuntime.Net481).WithJit(Jit.LegacyJit))
20-
.AddJob(Job.Default.WithRuntime(ClrRuntime.Net481).WithJit(Jit.RyuJit))
21-
.AddJob(Job.Default.WithRuntime(CoreRuntime.Core21))
22-
.AddJob(Job.Default.WithRuntime(CoreRuntime.Core31))
23-
.AddJob(Job.Default.WithRuntime(CoreRuntime.Core50))
24-
.AddJob(Job.Default.WithRuntime(CoreRuntime.Core60))
25-
.AddJob(Job.Default.WithRuntime(CoreRuntime.Core70))
2618
.AddJob(Job.Default.WithRuntime(CoreRuntime.Core80))
19+
.AddJob(Job.Default.WithRuntime(CoreRuntime.Core90))
20+
.AddJob(Job.Default.WithRuntime(CoreRuntime.Core10_0))
2721
;
2822

2923
var switcher = new BenchmarkSwitcher(new[] {

0 commit comments

Comments
 (0)