@@ -8,11 +8,11 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
88
99** File:** ` HdrHistogram/HdrHistogram.csproj `
1010
11- - [ ] ** 1.1** Change ` <TargetFrameworks> ` on line 4 from ` net8.0;netstandard2.0 ` to
11+ - [x ] ** 1.1** Change ` <TargetFrameworks> ` on line 4 from ` net8.0;netstandard2.0 ` to
1212 ` net10.0;net9.0;net8.0;netstandard2.0 ` .
1313 Verify: the element reads exactly ` <TargetFrameworks>net10.0;net9.0;net8.0;netstandard2.0</TargetFrameworks> ` .
1414
15- - [ ] ** 1.2** Add two ` <PropertyGroup> ` conditions for the Release ` DocumentationFile ` ,
15+ - [x ] ** 1.2** Add two ` <PropertyGroup> ` conditions for the Release ` DocumentationFile ` ,
1616 mirroring the existing block at lines 24–26.
1717 Add one block for ` net9.0 ` (` bin\Release\net9.0\HdrHistogram.xml ` ) and one for
1818 ` net10.0 ` (` bin\Release\net10.0\HdrHistogram.xml ` ), immediately after the
@@ -28,7 +28,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
2828
2929** File:** ` HdrHistogram.UnitTests/HdrHistogram.UnitTests.csproj `
3030
31- - [ ] ** 2.1** Change ` <TargetFrameworks> ` on line 4 from ` net8.0 ` to
31+ - [x ] ** 2.1** Change ` <TargetFrameworks> ` on line 4 from ` net8.0 ` to
3232 ` net10.0;net9.0;net8.0 ` .
3333 Verify: the element reads exactly ` <TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks> ` .
3434
@@ -41,7 +41,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
4141
4242** File:** ` HdrHistogram.Examples/HdrHistogram.Examples.csproj `
4343
44- - [ ] ** 3.1** Change ` <TargetFrameworks> ` on line 5 from ` net8.0 ` to ` net10.0 ` .
44+ - [x ] ** 3.1** Change ` <TargetFrameworks> ` on line 5 from ` net8.0 ` to ` net10.0 ` .
4545 Verify: the element reads exactly ` <TargetFrameworks>net10.0</TargetFrameworks> ` .
4646
4747> Covers acceptance criterion: ** AC-3** .
@@ -52,18 +52,18 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
5252
5353** File:** ` HdrHistogram.Benchmarking/HdrHistogram.Benchmarking.csproj `
5454
55- - [ ] ** 4.1** Change ` <TargetFrameworks> ` on line 5 from ` net8.0 ` to
55+ - [x ] ** 4.1** Change ` <TargetFrameworks> ` on line 5 from ` net8.0 ` to
5656 ` net10.0;net9.0;net8.0 ` .
5757 Verify: the element reads exactly ` <TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks> ` .
5858
59- - [ ] ** 4.2** Attempt a Release build of the benchmarking project:
59+ - [x ] ** 4.2** Attempt a Release build of the benchmarking project:
6060 ``` bash
6161 dotnet build HdrHistogram.Benchmarking/HdrHistogram.Benchmarking.csproj -c Release
6262 ```
6363 If the build succeeds, this task is done — BenchmarkDotNet 0.13.12 is compatible.
6464 If the build fails due to BenchmarkDotNet incompatibility with net10.0, proceed to task 4.3.
6565
66- - [ ] ** 4.3** * (Conditional — only if task 4.2 fails)* Upgrade both
66+ - [x ] ** 4.3** * (Conditional — only if task 4.2 fails)* Upgrade both
6767 ` BenchmarkDotNet ` and ` BenchmarkDotNet.Diagnostics.Windows ` to the latest
6868 stable version.
6969 Verify: ` dotnet build HdrHistogram.Benchmarking/HdrHistogram.Benchmarking.csproj -c Release `
@@ -78,7 +78,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
7878
7979** File:** ` .github/workflows/ci.yml `
8080
81- - [ ] ** 5.1** Replace the ` setup-dotnet ` step (lines 15–19) with a single step using
81+ - [x ] ** 5.1** Replace the ` setup-dotnet ` step (lines 15–19) with a single step using
8282 a multi-line ` dotnet-version ` scalar:
8383 ``` yaml
8484 - uses : actions/setup-dotnet@v4
@@ -102,12 +102,12 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
102102
103103**File:** `.devcontainer/Dockerfile`
104104
105- - [ ] **6.1** Change the `FROM` line (line 5) from
105+ - [x ] **6.1** Change the `FROM` line (line 5) from
106106 ` mcr.microsoft.com/dotnet/sdk:9.0-bookworm-slim` to
107107 ` mcr.microsoft.com/dotnet/sdk:10.0-bookworm-slim` .
108108 Verify : the first `FROM` line references `sdk:10.0-bookworm-slim`.
109109
110- - [ ] **6.2** Replace the single 8.0 runtime install (lines 6–8) with explicit
110+ - [x ] **6.2** Replace the single 8.0 runtime install (lines 6–8) with explicit
111111 installs of both the 8.0 and 9.0 runtimes via `dotnet-install.sh`, keeping both
112112 in the same `RUN` layer to avoid creating extra image layers :
113113 ` ` ` dockerfile
@@ -129,7 +129,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
129129
130130**File:** `spec/tech-standards/build-system.md`, approx. lines 24–26
131131
132- - [ ] **7.1** In the "Main Library (HdrHistogram.csproj)" section, update the XML
132+ - [x ] **7.1** In the "Main Library (HdrHistogram.csproj)" section, update the XML
133133 code block from :
134134 ` ` ` xml
135135 <TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks>
@@ -148,7 +148,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
148148
149149**File:** `spec/tech-standards/build-system.md`, approx. lines 35–37
150150
151- - [ ] **8.1** In the "Test Project" section, update the XML code block from :
151+ - [x ] **8.1** In the "Test Project" section, update the XML code block from :
152152 ` ` ` xml
153153 <TargetFramework>net8.0</TargetFramework>
154154 ` ` `
@@ -168,7 +168,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
168168
169169**File:** `spec/tech-standards/build-system.md`, approx. lines 42–45
170170
171- - [ ] **9.1** In the "Benchmarking Project" section, update the description text
171+ - [x ] **9.1** In the "Benchmarking Project" section, update the description text
172172 " Targets the current LTS runtime only (developer tool, not a shipped library):" to
173173 reflect multi-targeting, and update the XML code block from :
174174 ` ` ` xml
@@ -188,7 +188,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
188188
189189**File:** `spec/tech-standards/build-system.md`, approx. lines 226–228
190190
191- - [ ] **10.1** In the "Benchmark Configuration" section, replace the single target entry :
191+ - [x ] **10.1** In the "Benchmark Configuration" section, replace the single target entry :
192192 ` ` `
193193 - ` net8.0` (current LTS runtime)
194194 ` ` `
@@ -200,7 +200,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
200200 ` ` `
201201 Verify: the bullet list covers all three TFMs.
202202
203- - [ ] **10.2** *(Conditional — only if task 4.3 was executed)* Update the BenchmarkDotNet
203+ - [x ] **10.2** *(Conditional — only if task 4.3 was executed)* Update the BenchmarkDotNet
204204 version numbers in the "Benchmarking Project" dependencies code block
205205 (approx. lines 66–67) to match the upgraded version.
206206 Verify: the version string in the spec matches the version in
@@ -214,7 +214,7 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
214214
215215**File:** `spec/tech-standards/build-system.md`, approx. line 254
216216
217- - [ ] **11.1** In the "Prerequisites" section, change :
217+ - [x ] **11.1** In the "Prerequisites" section, change :
218218 ` ` `
219219 - .NET 8.0 SDK (or later)
220220 ` ` `
@@ -233,23 +233,23 @@ Cross-referenced against every acceptance criterion in `plan/ready/brief.md`.
233233These tasks confirm all acceptance criteria related to running the toolchain.
234234They must be performed **after** all implementation tasks above are complete.
235235
236- - [ ] **12.1** Run a Release build of the main library and confirm it succeeds for
236+ - [x ] **12.1** Run a Release build of the main library and confirm it succeeds for
237237 all four target frameworks :
238238 ` ` ` bash
239239 dotnet build HdrHistogram/HdrHistogram.csproj -c Release
240240 ` ` `
241241 Verify : build output shows `net10.0`, `net9.0`, `net8.0`, and `netstandard2.0`
242242 all built without errors.
243243
244- - [ ] **12.2** Run the full test suite and confirm all tests pass on all three
244+ - [x ] **12.2** Run the full test suite and confirm all tests pass on all three
245245 modern runtimes :
246246 ` ` ` bash
247247 dotnet test HdrHistogram.UnitTests/HdrHistogram.UnitTests.csproj -c Release
248248 ` ` `
249249 Verify : test results show three separate `net10.0`, `net9.0`, and `net8.0` runs,
250250 all green with zero failures.
251251
252- - [ ] **12.3** Pack the library and confirm all four TFM folders are present in
252+ - [x ] **12.3** Pack the library and confirm all four TFM folders are present in
253253 the produced `.nupkg` :
254254 ` ` ` bash
255255 dotnet pack HdrHistogram/HdrHistogram.csproj -c Release --no-build
@@ -266,6 +266,27 @@ They must be performed **after** all implementation tasks above are complete.
266266
267267---
268268
269+ ---
270+
271+ # # 13 — Code review fixes
272+
273+ Issues found during post-implementation review and resolved.
274+
275+ - [x] **13.1** BenchmarkDotNet version regression : the branch base had `0.13.12` but
276+ ` upstream/main` already upgraded to `0.15.8`.
277+ Updated `HdrHistogram.Benchmarking/HdrHistogram.Benchmarking.csproj` to `0.15.8`.
278+ Verified : ` dotnet build -c Release -p:TargetFrameworks=net9.0` succeeds.
279+
280+ - [x] **13.2** `spec/tech-standards/build-system.md` BenchmarkDotNet version block
281+ also reflected the old `0.13.12`.
282+ Updated both package references in the spec to `0.15.8` to match the csproj.
283+
284+ - [x] **13.3** `spec/tech-standards/build-system.md` TFM description table in the
285+ " Main Library" section was missing rows for `net9.0` and `net10.0`.
286+ Added `net10.0` (current LTS target), `net9.0` (STS target), and `net8.0` (LTS target) rows.
287+
288+ ---
289+
269290# # Acceptance Criterion Cross-Reference
270291
271292| Criterion | Tasks |
0 commit comments