Uncomment tests and update approved results

Kristoffer Lerbæk Pedersen · Havret · commit 3128c0443184 · 2023-08-25T22:12:52.000+02:00
diff --git a/test/Protobuf.System.Text.Json.Tests/DefaultIgnoreConditionTests.Should_not_ignore_default_non_nullable_properties_when_DefaultIgnoreCondition_set_to_WhenWritingNull.approved.json b/test/Protobuf.System.Text.Json.Tests/DefaultIgnoreConditionTests.Should_not_ignore_default_non_nullable_properties_when_DefaultIgnoreCondition_set_to_WhenWritingNull.approved.json
@@ -12,5 +12,6 @@
   "sfixed32Property": 0,
   "sfixed64Property": 0,
   "boolProperty": false,
-  "stringProperty": ""
+  "stringProperty": "",
+  "bytesProperty": ""
 }
diff --git a/test/Protobuf.System.Text.Json.Tests/DefaultIgnoreConditionTests.Should_not_ignore_default_properties_when_DefaultIgnoreCondition_set_to_Never.approved.json b/test/Protobuf.System.Text.Json.Tests/DefaultIgnoreConditionTests.Should_not_ignore_default_properties_when_DefaultIgnoreCondition_set_to_Never.approved.json
@@ -12,5 +12,6 @@
   "sfixed32Property": 0,
   "sfixed64Property": 0,
   "boolProperty": false,
-  "stringProperty": ""
+  "stringProperty": "",
+  "bytesProperty": ""
 }
diff --git a/test/Protobuf.System.Text.Json.Tests/JsonNamingPolicyTests.Should_ignore_PropertyNamingPolicy_when_UseProtobufJsonNames_set_to_true.approved.json b/test/Protobuf.System.Text.Json.Tests/JsonNamingPolicyTests.Should_ignore_PropertyNamingPolicy_when_UseProtobufJsonNames_set_to_true.approved.json
@@ -12,5 +12,6 @@
   "sfixed32Property": 0,
   "sfixed64Property": 0,
   "boolProperty": false,
-  "stringProperty": ""
+  "stringProperty": "",
+  "bytesProperty": ""
 }
diff --git a/test/Protobuf.System.Text.Json.Tests/JsonNamingPolicyTests.Should_serialize_message_with_primitive_types.approved.json b/test/Protobuf.System.Text.Json.Tests/JsonNamingPolicyTests.Should_serialize_message_with_primitive_types.approved.json
@@ -12,5 +12,6 @@
   "sfixed32property": 0,
   "sfixed64property": 0,
   "boolproperty": false,
-  "stringproperty": ""
+  "stringproperty": "",
+  "bytesproperty": ""
 }
diff --git a/test/Protobuf.System.Text.Json.Tests/Protos/simple_message.proto b/test/Protobuf.System.Text.Json.Tests/Protos/simple_message.proto
@@ -31,6 +31,5 @@ message SimpleMessage {
   
   string string_property = 14;
   
-  // TODO: Support bytes property
-  // bytes bytes_property = 15;
+  bytes bytes_property = 15;
 }
diff --git a/test/Protobuf.System.Text.Json.Tests/SimpleMessageTests.Should_serialize_message_with_primitive_types.approved.json b/test/Protobuf.System.Text.Json.Tests/SimpleMessageTests.Should_serialize_message_with_primitive_types.approved.json
@@ -12,5 +12,6 @@
   "sfixed32Property": 9,
   "sfixed64Property": 10,
   "boolProperty": true,
-  "stringProperty": "hello"
+  "stringProperty": "hello",
+  "bytesProperty": "YWJj"
 }
diff --git a/test/Protobuf.System.Text.Json.Tests/SimpleMessageTests.cs b/test/Protobuf.System.Text.Json.Tests/SimpleMessageTests.cs
@@ -1,5 +1,6 @@
 using System.Text.Json;
 using System.Text.Json.Protobuf.Tests;
+using Google.Protobuf;
 using Protobuf.System.Text.Json.Tests.Utils;
 using Shouldly;
 using SmartAnalyzers.ApprovalTestsExtensions;
@@ -28,9 +29,8 @@ public void Should_serialize_message_with_primitive_types()
             Sfixed32Property = 9,
             Sfixed64Property = 10,
             BoolProperty = true,
-            StringProperty = "hello"
-            // TODO: Support bytes property
-            // BytesProperty = ByteString.CopyFromUtf8("abc")
+            StringProperty = "hello",
+            BytesProperty = ByteString.CopyFromUtf8("abc")
         };
         var jsonSerializerOptions = TestHelper.CreateJsonSerializerOptions();
         
@@ -61,9 +61,8 @@ public void Should_deserialize_message_with_primitive_types()
             Sfixed32Property = 9,
             Sfixed64Property = 10,
             BoolProperty = true,
-            StringProperty = "hello"
-            // TODO: Support bytes property
-            // BytesProperty = ByteString.CopyFromUtf8("abc")
+            StringProperty = "hello",
+            BytesProperty = ByteString.CopyFromUtf8("abc")
         };
         var jsonSerializerOptions = TestHelper.CreateJsonSerializerOptions();
 

Original file line number	Diff line number	Diff line change
`@@ -12,5 +12,6 @@`
`12`	`12`	`"sfixed32Property": 0,`
`13`	`13`	`"sfixed64Property": 0,`
`14`	`14`	`"boolProperty": false,`
`15`		`- "stringProperty": ""`
	`15`	`+ "stringProperty": "",`
	`16`	`+ "bytesProperty": ""`
`16`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,5 @@ message SimpleMessage {`
`31`	`31`
`32`	`32`	`string string_property = 14;`
`33`	`33`
`34`		`- // TODO: Support bytes property`
`35`		`- // bytes bytes_property = 15;`
	`34`	`+ bytes bytes_property = 15;`
`36`	`35`	`}`