change filename vars to const char* (#8)

* change filenames to const char*

---------

Co-authored-by: Benjamin Brock <benjamin.brock@intel.com>

Author: gdinh

examples/benchmark_write.c

@@ -60,7 +60,7 @@ void flush_writes() {
 #endif
 }
 
-void delete_file(char* file_name) {
+void delete_file(const char* file_name) {
   char command[2048];
   snprintf(command, 2047, "rm %s", file_name);
   system(command);

include/binsparse/detail/parse_dataset.h

@@ -35,7 +35,7 @@ bsp_fdataset_info_t bsp_parse_fdataset_string(char* str) {
   }
 }
 
-char* bsp_get_file_extension(char* file_name) {
+const char* bsp_get_file_extension(const char* file_name) {
   int64_t len = strlen(file_name);
   for (int64_t i = len - 1; i >= 0; i--) {
     if (file_name[i] == '.') {

include/binsparse/hdf5_wrapper.h

@@ -7,7 +7,7 @@
 
 // Write an array to a dataset / file
 // Returns 0 on success, nonzero on error.
-int bsp_write_array(hid_t f, char* label, bsp_array_t array,
+int bsp_write_array(hid_t f, const char* label, bsp_array_t array,
                     int compression_level) {
   if (array.type == BSP_COMPLEX_FLOAT32 || array.type == BSP_COMPLEX_FLOAT64) {
     array = bsp_complex_array_to_fp(array);
@@ -61,7 +61,7 @@ int bsp_write_array(hid_t f, char* label, bsp_array_t array,
   return 0;
 }
 
-bsp_array_t bsp_read_array(hid_t f, char* label) {
+bsp_array_t bsp_read_array(hid_t f, const char* label) {
   hid_t dset = H5Dopen2(f, label, H5P_DEFAULT);
 
   if (dset == H5I_INVALID_HID) {
@@ -100,7 +100,7 @@ bsp_array_t bsp_read_array(hid_t f, char* label) {
   return array;
 }
 
-void bsp_write_attribute(hid_t f, char* label, char* string) {
+void bsp_write_attribute(hid_t f, const char* label, const char* string) {
   hid_t strtype = H5Tcopy(H5T_C_S1);
   H5Tset_size(strtype, strlen(string));
   H5Tset_cset(strtype, H5T_CSET_UTF8);
@@ -116,7 +116,7 @@ void bsp_write_attribute(hid_t f, char* label, char* string) {
   H5Sclose(dataspace);
 }
 
-char* bsp_read_attribute(hid_t f, char* label) {
+char* bsp_read_attribute(hid_t f, const char* label) {
   hid_t attribute = H5Aopen(f, label, H5P_DEFAULT);
   hid_t strtype = H5Aget_type(attribute);
 

include/binsparse/matrix_market/matrix_market_inspector.h

@@ -26,7 +26,7 @@ typedef struct bsp_mm_metadata {
   char* comments;
 } bsp_mm_metadata;
 
-bsp_mm_metadata bsp_mmread_metadata(char* file_path) {
+bsp_mm_metadata bsp_mmread_metadata(const char* file_path) {
   FILE* f = fopen(file_path, "r");
 
   assert(f != NULL);

include/binsparse/matrix_market/matrix_market_read.h

@@ -9,7 +9,8 @@
 #include <binsparse/matrix_market/matrix_market_inspector.h>
 #include <binsparse/matrix_market/matrix_market_type_t.h>
 
-bsp_matrix_t bsp_mmread_explicit_array(char* file_path, bsp_type_t value_type,
+bsp_matrix_t bsp_mmread_explicit_array(const char* file_path,
+                                       bsp_type_t value_type,
                                        bsp_type_t index_type) {
   bsp_mm_metadata metadata = bsp_mmread_metadata(file_path);
 
@@ -96,7 +97,7 @@ bsp_matrix_t bsp_mmread_explicit_array(char* file_path, bsp_type_t value_type,
   return matrix;
 }
 
-bsp_matrix_t bsp_mmread_explicit_coordinate(char* file_path,
+bsp_matrix_t bsp_mmread_explicit_coordinate(const char* file_path,
                                             bsp_type_t value_type,
                                             bsp_type_t index_type) {
   bsp_mm_metadata metadata = bsp_mmread_metadata(file_path);
@@ -254,7 +255,7 @@ bsp_matrix_t bsp_mmread_explicit_coordinate(char* file_path,
   return matrix;
 }
 
-bsp_matrix_t bsp_mmread_explicit(char* file_path, bsp_type_t value_type,
+bsp_matrix_t bsp_mmread_explicit(const char* file_path, bsp_type_t value_type,
                                  bsp_type_t index_type) {
   bsp_mm_metadata metadata = bsp_mmread_metadata(file_path);
 
@@ -267,7 +268,7 @@ bsp_matrix_t bsp_mmread_explicit(char* file_path, bsp_type_t value_type,
   }
 }
 
-bsp_matrix_t bsp_mmread(char* file_path) {
+bsp_matrix_t bsp_mmread(const char* file_path) {
   bsp_mm_metadata metadata = bsp_mmread_metadata(file_path);
 
   bsp_type_t value_type;

include/binsparse/matrix_market/matrix_market_write.h

@@ -6,7 +6,7 @@
 
 #include <binsparse/matrix_market/matrix_market_type_t.h>
 
-void bsp_mmwrite(char* file_path, bsp_matrix_t matrix) {
+void bsp_mmwrite(const char* file_path, bsp_matrix_t matrix) {
   FILE* f = fopen(file_path, "w");
 
   assert(f != NULL);

include/binsparse/read_matrix.h

@@ -105,7 +105,7 @@ bsp_matrix_t bsp_read_matrix_from_group(hid_t f) {
   return matrix;
 }
 
-size_t bsp_final_dot(char* str) {
+size_t bsp_final_dot(const char* str) {
   size_t dot_idx = 0;
   for (size_t i = 0; str[i] != '\0'; i++) {
     if (str[i] == '.') {
@@ -115,7 +115,7 @@ size_t bsp_final_dot(char* str) {
   return dot_idx;
 }
 
-bsp_matrix_t bsp_read_matrix(char* file_name, char* group) {
+bsp_matrix_t bsp_read_matrix(const char* file_name, char* group) {
   if (group == NULL) {
     size_t idx = bsp_final_dot(file_name);
     if (strcmp(file_name + idx, ".hdf5") == 0 ||

include/binsparse/write_matrix.h

@@ -121,7 +121,7 @@ int bsp_write_matrix_to_group(hid_t f, bsp_matrix_t matrix, cJSON* user_json,
   return 0;
 }
 
-int bsp_write_matrix(char* fname, bsp_matrix_t matrix, char* group,
+int bsp_write_matrix(const char* fname, bsp_matrix_t matrix, char* group,
                      cJSON* user_json, int compression_level) {
   if (group == NULL) {
     hid_t f = H5Fcreate(fname, H5F_ACC_TRUNC, H5P_DEFAULT, H5P_DEFAULT);