Skip to content

Commit 3032fc2

Browse files
author
Amin Mahboubi
authored
chore: upgrade xml-parser (#40)
1 parent a79803a commit 3032fc2

8 files changed

Lines changed: 1510 additions & 2272 deletions

File tree

package.json

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,34 +40,33 @@
4040
},
4141
"dependencies": {
4242
"@braintree/sanitize-url": "^5.0.0",
43-
"@rgrove/parse-xml": "^2.0.4",
43+
"@rgrove/parse-xml": "^3.0.0",
4444
"@types/linkifyjs": "^2.1.3",
45-
"@types/rgrove__parse-xml": "^1.1.1",
46-
"dayjs": "^1.10.3",
45+
"dayjs": "^1.10.4",
4746
"ical-expander": "^3.1.0",
4847
"linkifyjs": "^2.1.9",
4948
"react-markdown": "^5.0.3",
5049
"react-virtuoso": "^0.20.3"
5150
},
5251
"devDependencies": {
53-
"@size-limit/preset-big-lib": "^4.9.1",
54-
"@types/react": "^17.0.0",
55-
"@types/react-dom": "^17.0.0",
56-
"@types/react-test-renderer": "^17.0.0",
52+
"@size-limit/preset-big-lib": "^4.9.2",
53+
"@types/react": "^17.0.2",
54+
"@types/react-dom": "^17.0.1",
55+
"@types/react-test-renderer": "^17.0.1",
5756
"cssnano": "^4.1.10",
5857
"docz": "^2.3.1",
59-
"gatsby-plugin-styled-components": "^3.8.0",
58+
"gatsby-plugin-styled-components": "^3.10.0",
6059
"husky": "^4.3.8",
6160
"react": "^17.0.1",
6261
"react-dom": "^17.0.1",
6362
"react-test-renderer": "^17.0.1",
6463
"rollup-plugin-ignore-import": "^1.3.2",
6564
"rollup-plugin-scss": "^2.6.1",
66-
"size-limit": "^4.9.1",
65+
"size-limit": "^4.9.2",
6766
"styled-components": "^5.2.1",
6867
"tsdx": "^0.14.1",
6968
"tslib": "^2.1.0",
70-
"typescript": "^4.1.3"
69+
"typescript": "^4.1.5"
7170
},
7271
"husky": {
7372
"hooks": {

src/parser/MMLTag.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
import { Element as XmlElement, Text as XmlText } from '@rgrove/parse-xml';
1+
import { XmlElement, XmlText } from '@rgrove/parse-xml';
2+
3+
function isXmlElement(node: XmlElement | XmlText): node is XmlElement {
4+
return !!(node as XmlElement).children;
5+
}
26

37
/**
48
* MMLTag - Xml tag converted to this MMLTag
@@ -19,7 +23,7 @@ export class MMLTag {
1923

2024
getText() {
2125
if (this.node.type === 'text') return this.node.text;
22-
else if (this.node.children && this.node.children.length) return (this.node.children[0] as XmlText).text;
26+
else if (isXmlElement(this.node) && this.node.children.length) return (this.node.children[0] as XmlText).text;
2327
return '';
2428
}
2529

0 commit comments

Comments
 (0)