Skip to content

Commit 530ad3d

Browse files
committed
[Contributing] Typo fix and review update
1 parent 03946ec commit 530ad3d

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Governance model
99

1010
The project has a core team of **maintainers** who are long-term contributors and responsible for coordinating the project. There is also a set of one-time or short period **contributors**. We consider everyone a contributor who reports issues, opens pull requests, or takes part in issue discussions. Any such contribution is welcome. Maintainers have commit access to the repository and will review and merge pull requests. Becoming a maintainer is possible for everyone who wants to help maintaining and shaping the project and to take over more responsibility. Requests to become a maintainer need to be approved by the existing maintainers.
1111

12-
Any addition to the code happens via pull requests (there are only very few exceptions in which someone pushes directly to master, see below for more information). Thus, any contribution will be reviewed before it is merged. Bug fixes and other contributions to the API will undergo this pragmatic approach. Format or API changes, especially those that would lead to breaking changes, will be discussed via the issue tracker and video meetings and need to be agreed on by the maintainters. We aim at consensus decisions, but where this is not possible decisions are made by majority vote among the maintainers.
12+
Any addition to the code happens via pull requests (there are only very few exceptions in which someone pushes directly to master, see below for more information). Thus, any contribution will be reviewed before it is merged. Bug fixes and other contributions to the API will undergo this pragmatic approach. Format or API changes, especially those that would lead to breaking changes, will be discussed via the issue tracker and video meetings and need to be agreed on by the maintainers. We aim at consensus decisions, but where this is not possible decisions are made by majority vote among the maintainers.
1313

1414

1515
Contributing
@@ -67,12 +67,12 @@ Each pull request that passes all builds and tests should be reviewed by at leas
6767
If a contribution is rather complex or leads to significant API changes, the respective pull request should be
6868
reviewed by two other developers.
6969
In such cases the first reviewer or the contributor should request a second review in a comment.
70-
70+
To streamline the review process reviewers are encouraged to use the github "review" option.
7171

7272
Testing
7373
-------
7474

75-
* Unit test can be found in the test sub directory. Currently, the test coverage is a bit low but we are working on improving it.
75+
* Unit tests can be found in the test sub directory. Currently, the test coverage is a bit low but we are working on improving it.
7676

7777
* Provide a unit test for every class, method or function.
7878

0 commit comments

Comments
 (0)