[property] Change DType Confirmation

Changing dtype confirmation, adding exceptions for dtypes possessing
string type values to allow appending with new values.

Fixing issue #318.

Author: fschrader1992

odml/property.py

@@ -617,9 +617,12 @@ def append(self, obj, strict=True):
         if len(new_value) > 1:
             raise ValueError("odml.property.append: Use extend to add a list of values!")
 
+        special_dtypes = ["url", "person", "text"]
         if len(new_value) > 0 and strict and dtypes.infer_dtype(new_value[0]) != self.dtype:
-            raise ValueError("odml.Property.append: "
-                             "passed value data type does not match dtype!")
+
+            if not (dtypes.infer_dtype(new_value[0]) == "string" and self.dtype in special_dtypes):
+                raise ValueError("odml.Property.append: "
+                                 "passed value data type does not match dtype!")
 
         if not self._validate_values(new_value):
             raise ValueError("odml.Property.append: passed value(s) cannot be converted "

test/test_property.py

@@ -187,6 +187,27 @@ def test_value_append(self):
         self.assertEqual(p6.value, [0])
         self.assertEqual(p6.values, [0])
 
+        p7 = Property(name="prop", value=["A Abraham", "B Barnes", "C Clark"], dtype=DType.person)
+        p7.append("D Dickins")
+        self.assertEqual(len(p7), 4)
+        self.assertRaises(ValueError, p7.append, 1)
+        self.assertRaises(ValueError, p7.append, 1.3)
+        self.assertRaises(ValueError, p7.append, True)
+
+        p8 = Property(name="prop", value=["https://en.wikipedia.org/wiki/Earth"], dtype=DType.url)
+        p8.append("https://en.wikipedia.org/wiki/Mars")
+        self.assertEqual(len(p8), 2)
+        self.assertRaises(ValueError, p8.append, 1)
+        self.assertRaises(ValueError, p8.append, 1.3)
+        self.assertRaises(ValueError, p8.append, True)
+
+        p9 = Property(name="prop", value=["Earth is No. 3."], dtype=DType.text)
+        p9.append("Mars is No. 4.")
+        self.assertEqual(len(p9), 2)
+        self.assertRaises(ValueError, p9.append, 1)
+        self.assertRaises(ValueError, p9.append, 1.3)
+        self.assertRaises(ValueError, p9.append, True)
+
     def test_value_extend(self):
         prop = Property(name="extend")