Skip to content

Commit 4c29808

Browse files
committed
Converters package cleanup
- Use simplified import of classes where applicable - Update documentation and docstrings to new package structure
1 parent 4c130e4 commit 4c29808

8 files changed

Lines changed: 30 additions & 22 deletions

File tree

doc/tools.rst

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,44 +14,50 @@ Tools
1414
=====
1515
Several tools are provided with the :py:mod:`odml.tools` package.
1616

17-
ODMLParser
17+
DictParser
1818
----------
19-
.. automodule:: odml.tools.odmlparser
19+
.. automodule:: odml.tools.dict_parser
2020
:members:
2121
:inherited-members:
2222
:undoc-members:
2323

24-
XMLParser
25-
---------
26-
.. automodule:: odml.tools.xmlparser
24+
ODMLParser
25+
----------
26+
.. automodule:: odml.tools.odmlparser
2727
:members:
2828
:inherited-members:
2929
:undoc-members:
3030

31-
DictParser
32-
----------
33-
.. automodule:: odml.tools.dict_parser
31+
RDFConverter
32+
----------------
33+
.. automodule:: odml.tools.rdf_converter
3434
:members:
3535
:inherited-members:
3636
:undoc-members:
3737

38-
FormatConverter
39-
----------------
40-
.. automodule:: odml.tools.format_converter
38+
XMLParser
39+
---------
40+
.. automodule:: odml.tools.xmlparser
4141
:members:
4242
:inherited-members:
4343
:undoc-members:
4444

45-
VersionConverter
45+
.. _converters:
46+
47+
Convenience converters
48+
======================
49+
Several convenience converters are provided with the :py:mod:`odml.tools.converters` package.
50+
51+
FormatConverter
4652
----------------
47-
.. automodule:: odml.tools.version_converter
53+
.. automodule:: odml.tools.converters.format_converter
4854
:members:
4955
:inherited-members:
5056
:undoc-members:
5157

52-
RDFConverter
58+
VersionConverter
5359
----------------
54-
.. automodule:: odml.tools.rdf_converter
60+
.. automodule:: odml.tools.converters.version_converter
5561
:members:
5662
:inherited-members:
5763
:undoc-members:

odml/scripts/odml_convert.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
import odml
3737

38-
from odml.tools.converters.version_converter import VersionConverter as VerConf
38+
from odml.tools.converters import VersionConverter as VerConf
3939

4040
try:
4141
unicode = unicode

odml/scripts/odml_to_rdf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
import odml
3838

3939
from odml.tools.odmlparser import ODMLReader, ODMLWriter
40-
from odml.tools.converters.version_converter import VersionConverter as VerConf
40+
from odml.tools.converters import VersionConverter as VerConf
4141

4242
try:
4343
unicode = unicode

odml/tools/dict_parser.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@ def to_odml(self, parsed_doc):
138138

139139
elif self.parsed_doc.get('odml-version') != FORMAT_VERSION:
140140
msg = ("Cannot parse odML document with format version '%s'. \n"
141-
"\tUse the 'tools.VersionConverter' to import previous odML formats."
141+
"\tUse the 'VersionConverter' from 'odml.tools.converters' "
142+
"to import previous odML formats."
142143
% self.parsed_doc.get('odml-version'))
143144
raise InvalidVersionException(msg)
144145

odml/tools/xmlparser.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,8 @@ def _handle_version(root):
182182
"in <odML> tag.\n")
183183
elif root.attrib['version'] != FORMAT_VERSION:
184184
msg = ("Cannot parse odML document with format version '%s'. \n"
185-
"\tUse the 'tools.VersionConverter' to import previous odML formats."
185+
"\tUse the 'VersionConverter' from 'odml.tools.converters' "
186+
"to import previous odML formats."
186187
% root.attrib['version'])
187188
raise InvalidVersionException(msg)
188189

test/test_format_converter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import unittest
44
from contextlib import contextmanager
55

6-
from odml.tools.converters.format_converter import FormatConverter
6+
from odml.tools.converters import FormatConverter
77

88
FC = FormatConverter
99

test/test_version_converter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from contextlib import contextmanager
1414
from lxml import etree as ET
1515
from odml.terminology import REPOSITORY_BASE
16-
from odml.tools.converters.version_converter import VersionConverter
16+
from odml.tools.converters import VersionConverter
1717

1818
try:
1919
unicode = unicode

test/test_version_converter_integration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import unittest
1010

1111
from odml import load
12-
from odml.tools.converters.version_converter import VersionConverter as VC
12+
from odml.tools.converters import VersionConverter as VC
1313

1414

1515
class TestVersionConverterIntegration(unittest.TestCase):

0 commit comments

Comments
 (0)