Skip to content

Commit 2084033

Browse files
committed
[section] Loose merge on link and include
Link and include setters need to be not strict on merges, since otherwise finalizing a document with terminologies will fail.
1 parent bb95670 commit 2084033

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

odml/section.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,10 @@ def include(self, new_value):
134134
if self._include is not None:
135135
self.clean()
136136
self._include = new_value
137-
self.merge(new_section)
137+
138+
# strict needs to be False, otherwise finalizing a document will
139+
# basically always fail.
140+
self.merge(new_section, strict=False)
138141

139142
@property
140143
def link(self):
@@ -172,7 +175,10 @@ def link(self, new_value):
172175
if self._link is not None:
173176
self.clean()
174177
self._link = new_value
175-
self.merge(new_section)
178+
179+
# strict needs to be False, otherwise finalizing a document will
180+
# basically always fail.
181+
self.merge(new_section, strict=False)
176182

177183
@property
178184
def definition(self):

0 commit comments

Comments
 (0)