Skip to content

Expose or retire wallet API routes with tests #63

Description

@pragmaticAweds

Context

wallet.controller.ts has a listWallets handler and wallet.services.ts creates a wallet repository, but wallet.routes.ts does not register any route. This leaves the wallet module in a half-implemented state: it is present in the codebase but not reachable through the API.

Scope

  • Decide whether wallet listing should be a supported API endpoint or the unused module should be removed from routing docs
  • If supported, register the wallet route under the appropriate v1 router
  • Add authentication/admin requirements appropriate for listing wallets
  • Add controller/route tests for success, auth failure, and database-not-ready behavior
  • Ensure response shape matches shared API conventions
  • Update README or API docs if a public route is added

Out of Scope

  • Wallet creation or balance mutation endpoints
  • Chain balance synchronization
  • Large platform permission redesign

Acceptance Criteria

  • Wallet module is no longer dormant or misleading
  • Any exposed wallet route has access control and tests
  • Tests cover expected failure responses
  • bun run type-check passes
  • bun run test passes
  • bun run lint passes

Suggested Files or Packages

  • src/components/v1/wallet/
  • src/components/v1/routes.v1.ts
  • src/__tests__/
  • README.md

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions