Skip to content

cef_host variant guard hard-fails opt-in from-source builds lacking the patched framework #26

Description

@wenkaifan0720

Follow-up from the #25 audit (finding #3, low severity, PLAUSIBLE — deferred).

native/cef_host/CEF_FRAMEWORK_VARIANT=campus-webauthn-h264 is committed as the repo default, so build_cef_host.sh's new variant guard (:63) hard-fails every from-source cef_host build whose CEF_ROOT lacks the patched framework — and build-cef-from-source.sh is arm64-only, so x86_64 can never satisfy it.

Scope (verified): the normal pod-install path is fetch-or-skip and is unaffected (fetch_cef_host.sh fails open on non-arm64 / network miss; the embed phase skips when prebuilt/cef_host.app is absent; build_cef_host.sh is not auto-invoked). Impact is confined to explicit opt-in from-source builds: the documented FLUTTER_CEF_FROM_SOURCE=1 co-dev loop, a manual x86_64 build, or an offline arm64 build before the patched prebuilt is published — all of which previously produced a quick stock host and now hard-fail.

Options (design call):

  • Gate the guard so it only enforces on the signed dev/prod release build, not every build_cef_host.sh invocation.
  • Handle x86_64 explicitly (stock-only / skip the guard, since no patched x64 framework exists).
  • Keep a FLUTTER_CEF_FROM_SOURCE path that can build a stock host without the patched framework.

Not merge-blocking; the fix that shipped in #25 (scheme guard, hash fold-in, doc correction) covered the other three findings.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions