Skip to content

Commit 3ba12aa

Browse files
javier-godoypaodb
authored andcommitted
refactor: deduplicate theme-setting script generation
1 parent b4517d7 commit 3ba12aa

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

src/main/java/com/flowingcode/vaadin/addons/demo/TabbedDemo.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,11 +335,13 @@ public static void applyThemeAttribute(Element element, String theme) {
335335

336336
String script;
337337
if (element.getTag().equalsIgnoreCase("iframe")) {
338-
script = "this.contentWindow.document.documentElement.setAttribute('theme', $0)";
338+
script = "let e = this.contentWindow.document.documentElement;";
339339
} else {
340-
script = "document.documentElement.setAttribute('theme', $0);";
340+
script = "let e = document.documentElement;";
341341
}
342342

343+
script += "e.setAttribute('theme', $0);";
344+
343345
element.executeJs(script, theme);
344346

345347
Component c = element.getComponent().get();

0 commit comments

Comments
 (0)