Skip to content

Commit bbb11ef

Browse files
committed
Improve backoff rules
Fixes AttributeError when the exception wasn't an HTTPError
1 parent 6e495f8 commit bbb11ef

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

update.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@
2121

2222
@backoff.on_exception(backoff.expo,
2323
(requests.exceptions.RequestException, urllib3.exceptions.ProtocolError, urllib3.exceptions.ReadTimeoutError),
24-
giveup=lambda e: 400 <= e.response.status_code < 500, logger='reporter')
24+
logger='reporter', max_value=20)
25+
@backoff.on_exception(backoff.expo, requests.exceptions.HTTPError,
26+
giveup=lambda e: 400 <= e.response.status_code < 500, logger='reporter', max_value=20)
2527
def download_file(session, url, dest):
2628
with session.get(url, stream=True, timeout=10) as r:
2729
r.raise_for_status()

0 commit comments

Comments
 (0)