ensure target rate is unsigned everywhere

Author: tomysshadow

FlashpointSecurePlayer/OldCPUSimulator.cs

@@ -79,7 +79,7 @@ public void Activate(string templateName, ref ProcessStartInfo softwareProcessSt
 
             // sigh... okay
             // first, we check the target rate
-            if (!int.TryParse(Environment.ExpandEnvironmentVariables(oldCPUSimulatorElement.TargetRate), out int targetRate)) {
+            if (!ulong.TryParse(Environment.ExpandEnvironmentVariables(oldCPUSimulatorElement.TargetRate), out ulong targetRate)) {
                 throw new InvalidOldCPUSimulatorException("The Target Rate is required.");
             }
 
@@ -90,8 +90,6 @@ public void Activate(string templateName, ref ProcessStartInfo softwareProcessSt
 
             // next... we need to check if the CPU speed is actually faster than
             // what we want to underclock to
-            long maxRate = 0;
-
             ProcessStartInfo oldCPUSimulatorProcessStartInfo = new ProcessStartInfo(OLD_CPU_SIMULATOR_PATH, "--dev-get-max-mhz") {
                 UseShellExecute = false,
                 RedirectStandardError = false,
@@ -117,20 +115,20 @@ public void Activate(string templateName, ref ProcessStartInfo softwareProcessSt
                         oldCPUSimulatorProcessStandardOutput = oldCPUSimulatorProcess.StandardOutput.ReadToEnd();
                     }
 
-                    if (oldCPUSimulatorProcess.ExitCode != 0 || !long.TryParse(oldCPUSimulatorProcessStandardOutput.Split('\n').Last(), out maxRate)) {
+                    if (oldCPUSimulatorProcess.ExitCode != 0 || !ulong.TryParse(oldCPUSimulatorProcessStandardOutput.Split('\n').Last(), out ulong maxRate)) {
                         throw new InvalidOldCPUSimulatorException("Failed to get Max Rate.");
                     }
+
+                    // if our CPU is too slow, just ignore the modification
+                    if (targetRate >= maxRate) {
+                        return;
+                    }
                 }
             } catch (Exception ex) {
                 LogExceptionToLauncher(ex);
                 throw new InvalidOldCPUSimulatorException("Failed to get Max Rate.");
             }
 
-            // if our CPU is too slow, just ignore the modification
-            if (targetRate >= maxRate) {
-                return;
-            }
-
             switch (modeElement.Name) {
                 case ModeElement.NAME.WEB_BROWSER:
                 // server mode, need to restart the whole app