[FlashpointManager] Streamline download status, info file checking

Author: WumboSpasm

FlashpointManager/src/Common.cs

@@ -21,6 +21,9 @@ public class Component : Category
             public string Path { get; set; }
             public string[] Depends { get; set; } = new string[] { };
 
+            public string InfoFile { get => System.IO.Path.Combine(FPM.SourcePath, "Components", $"{ID}.txt"); }
+            public bool Downloaded { get => File.Exists(InfoFile); }
+
             public Component(XmlNode node) : base(node)
             {
                 // URL
@@ -293,7 +296,7 @@ public static void SyncManager()
                     {
                         var component = node.Tag as Component;
 
-                        if (File.Exists(Path.Combine(SourcePath, "Components", $"{component.ID}.txt")))
+                        if (component.Downloaded)
                         {
                             ComponentTracker.Downloaded.Add(component);
                             node.Checked = true;
@@ -339,8 +342,7 @@ void AddToQueue(Component component, long oldSize)
 
                     if (ComponentTracker.Downloaded.Any(item => item.ID == component.ID))
                     {
-                        string infoFile = Path.Combine(SourcePath, "Components", $"{component.ID}.txt");
-                        string[] componentData = File.ReadLines(infoFile).First().Split(' ');
+                        string[] componentData = File.ReadLines(component.InfoFile).First().Split(' ');
 
                         update = componentData[0] != component.Hash;
                         oldSize = long.Parse(componentData[1]);
@@ -407,10 +409,7 @@ public static void VerifySourcePath()
                 {
                     if (isFlashpoint || node.Name != "component") return;
 
-                    var component = new Component(node);
-                    string infoPath = Path.Combine(SourcePath, "Components", $"{component.ID}.txt");
-
-                    if (File.Exists(infoPath))
+                    if (new Component(node).Downloaded)
                     {
                         isFlashpoint = true;
                     }
@@ -440,15 +439,14 @@ public static bool CheckDependencies(bool alertDepends = true)
                     if (node.Checked && node.Tag.GetType().ToString().EndsWith("Component"))
                     {
                         var component = node.Tag as Component;
-                        string infoPath = Path.Combine(SourcePath, "Components", $"{component.ID}.txt");
-
-                        if (File.Exists(infoPath))
+                        
+                        if (component.Downloaded)
                         {
-                            requiredDepends.AddRange(File.ReadLines(infoPath).First().Split(' ').Skip(2).ToArray());
+                            requiredDepends.AddRange(File.ReadLines(component.InfoFile).First().Split(' ').Skip(2).ToArray());
                         }
                         else
                         {
-                            requiredDepends.AddRange((node.Tag as Component).Depends);
+                            requiredDepends.AddRange(component.Depends);
                         }
                     }
                 });
@@ -511,10 +509,9 @@ public static long GetTotalSize(TreeView sourceTree)
                     if (node.Checked && node.Tag.GetType().ToString().EndsWith("Component"))
                     {
                         var component = node.Tag as Component;
-                        string infoPath = Path.Combine(SourcePath, "Components", $"{component.ID}.txt");
 
-                        size += File.Exists(infoPath)
-                            ? long.Parse(File.ReadLines(infoPath).First().Split(' ')[1])
+                        size += component.Downloaded
+                            ? long.Parse(File.ReadLines(component.InfoFile).First().Split(' ')[1])
                             : component.Size;
                     }
                 });

FlashpointManager/src/Forms/Operate.cs

@@ -234,8 +234,7 @@ private void ExtractComponents()
 
         private void RemoveComponents()
         {
-            string infoFile = Path.Combine(FPM.SourcePath, "Components", $"{workingComponent.ID}.txt");
-            string[] infoText = File.ReadLines(infoFile).Skip(1).ToArray();
+            string[] infoText = File.ReadLines(workingComponent.InfoFile).Skip(1).ToArray();
 
             long removedFiles = 0;
             long totalFiles = infoText.Length - 1;
@@ -272,7 +271,7 @@ private void RemoveComponents()
                 });
             }
 
-            FPM.DeleteFileAndDirectories(infoFile);
+            FPM.DeleteFileAndDirectories(workingComponent.InfoFile);
         }
 
         private void ApplyComponents()
@@ -290,8 +289,7 @@ private void ApplyComponents()
                 try { File.Move(tempFile, destFile); } catch { }
             }
 
-            string destInfoFile = Path.Combine(FPM.SourcePath, "Components", $"{workingComponent.ID}.txt");
-            try { File.Move(tempInfoFile, destInfoFile); } catch { }
+            try { File.Move(tempInfoFile, workingComponent.InfoFile); } catch { }
         }
 
         public static void DeleteTempDirectory()