[FlashpointManager] Improve startup times and checkbox performance

Author: WumboSpasm

FlashpointManager/src/Common.cs

@@ -23,6 +23,9 @@ public class Component : Category
             public string InfoFile { get => System.IO.Path.Combine(FPM.SourcePath, "Components", ID); }
             public bool Downloaded { get => File.Exists(InfoFile); }
 
+            // This is used to get around edge cases where check events trigger despite the checkbox value not changing
+            public bool Checked { get; set; } = false;
+
             public Component(XmlNode node) : base(node)
             {
                 // URL
@@ -146,6 +149,9 @@ public static class FPM
             // The parsed component list XML
             public static XmlDocument XmlTree { get; } = new XmlDocument();
 
+            // Tracks if the manager has been initialized yet
+            public static bool Ready { get; set; } = false;
+
             // Name of configuration file
             public static string ConfigFile { get; set; } = "fpm.cfg";
             // Internet locations of component list XMLs
@@ -174,6 +180,8 @@ public static class RepoXmlTemplates
 
             // Total size of every downloaded component; managed by SyncManager() function
             public static long DownloadedSize { get; set; } = 0;
+            // Projected size difference based on changed values of checkboxes
+            public static long ModifiedSize { get; set; } = 0;
 
             // Object providing easy access to certain groups of components; managed by SyncManager() function
             public static class ComponentTracker
@@ -286,6 +294,7 @@ public static void SyncManager(bool init = false)
                 });
 
                 DownloadedSize = ComponentTracker.Downloaded.Sum(c => long.Parse(File.ReadLines(c.InfoFile).First().Split(' ')[1]));
+                ModifiedSize = 0;
 
                 var componentList = new List<string>();
 
@@ -418,6 +427,8 @@ public static void SyncManager(bool init = false)
                         Main.CustomRepo.Checked = true;
                         break;
                 }
+
+                Ready = true;
             }
 
             // Deletes a file as well as any directories made empty by its deletion

FlashpointManager/src/Forms/Main.cs

@@ -67,20 +67,20 @@ public void ComponentList_BeforeCheck(object sender, TreeViewCancelEventArgs e)
 
         public void ComponentList_AfterCheck(object sender, TreeViewEventArgs e)
         {
-            long size = 0;
+            if (!e.Node.Tag.GetType().ToString().EndsWith("Component")) return;
 
-            FPM.IterateList(ComponentList.Nodes, node =>
-            {
-                if (!node.Checked || !node.Tag.GetType().ToString().EndsWith("Component")) return;
+            var component = e.Node.Tag as Component;
 
-                var component = node.Tag as Component;
+            if (component.Checked == e.Node.Checked) return;
+            component.Checked = e.Node.Checked;
 
-                size += FPM.ComponentTracker.Downloaded.Exists(c => c.ID == component.ID)
-                    ? long.Parse(File.ReadLines(component.InfoFile).First().Split(' ')[1])
-                    : component.Size;
-            });
+            if (!FPM.Ready) return;
+            
+            FPM.ModifiedSize += (e.Node.Checked ? 1 : -1) * (FPM.ComponentTracker.Downloaded.Exists(c => c.ID == component.ID)
+                ? long.Parse(File.ReadLines(component.InfoFile).First().Split(' ')[1])
+                : component.Size);
 
-            ChangeButton.Text = $"Apply changes ({FPM.GetFormattedBytes(size - FPM.DownloadedSize)})";
+            ChangeButton.Text = $"Apply changes ({FPM.GetFormattedBytes(FPM.ModifiedSize)})";
             ChangeButton.Enabled = true;
         }