[FlashpointManager] Fix duplicate items in update tab, reduce File.Exists() use

Author: WumboSpasm

FlashpointManager/src/Common.cs

@@ -297,41 +297,17 @@ public static void SyncManager()
 
                 DownloadedSize = ComponentTracker.Downloaded.Sum(c => long.Parse(File.ReadLines(c.InfoFile).First().Split(' ')[1]));
 
-                long totalSizeChange = 0;
-
-                void AddToQueue(Component component, long oldSize)
-                {
-                    long sizeChange = component.Size - oldSize;
-                    totalSizeChange += sizeChange;
-
-                    string displayedSize = GetFormattedBytes(sizeChange);
-                    if (displayedSize[0] != '-') displayedSize = "+" + displayedSize;
-
-                    var item = new ListViewItem();
-                    item.Text = component.Title;
-                    item.SubItems.Add(component.Description);
-                    item.SubItems.Add(component.LastUpdated);
-                    item.SubItems.Add(displayedSize);
-
-                    Main.UpdateList.Items.Add(item);
-                    ComponentTracker.Outdated.Add(component);
-                }
-
                 IterateXML(XmlTree.GetElementsByTagName("list")[0].ChildNodes, node =>
                 {
                     if (node.Name != "component") return;
 
                     var component = new Component(node);
-
                     bool update = false;
-                    long oldSize = 0;
 
-                    if (ComponentTracker.Downloaded.Any(item => item.ID == component.ID))
+                    if (ComponentTracker.Downloaded.Exists(c => c.ID == component.ID))
                     {
-                        string[] componentData = File.ReadLines(component.InfoFile).First().Split(' ');
-
-                        update = componentData[0] != component.Hash;
-                        oldSize = long.Parse(componentData[1]);
+                        string localHash = File.ReadLines(component.InfoFile).First().Split(' ')[0];
+                        update = localHash != component.Hash;
                     }
                     else if (component.Required)
                     {
@@ -340,19 +316,44 @@ void AddToQueue(Component component, long oldSize)
 
                     if (update)
                     {
-                        AddToQueue(component, oldSize);
+                        ComponentTracker.Outdated.Add(component);
 
                         foreach (string dependID in component.Depends)
                         {
-                            if (!ComponentTracker.Downloaded.Any(item => item.ID == dependID))
+                            if (!ComponentTracker.Downloaded.Exists(c => c.ID == dependID))
                             {
                                 var query = Main.ComponentList.Nodes.Find(dependID, true);
-                                if (query.Length > 0) AddToQueue(query[0].Tag as Component, 0);
+                                if (query.Length > 0) ComponentTracker.Outdated.Add(query[0].Tag as Component);
                             }
                         }
                     }
                 });
 
+                ComponentTracker.Outdated = ComponentTracker.Outdated.Distinct().ToList();
+
+                long totalSizeChange = 0;
+
+                foreach (var component in ComponentTracker.Outdated)
+                {
+                    long oldSize = ComponentTracker.Downloaded.Exists(c => c.ID == component.ID)
+                        ? long.Parse(File.ReadLines(component.InfoFile).First().Split(' ')[1])
+                        : 0;
+
+                    long sizeChange = component.Size - oldSize;
+                    totalSizeChange += sizeChange;
+
+                    string displayedSize = GetFormattedBytes(sizeChange);
+                    if (displayedSize[0] != '-') displayedSize = "+" + displayedSize;
+
+                    var item = new ListViewItem();
+                    item.Text = component.Title;
+                    item.SubItems.Add(component.Description);
+                    item.SubItems.Add(component.LastUpdated);
+                    item.SubItems.Add(displayedSize);
+
+                    Main.UpdateList.Items.Add(item);
+                }
+
                 Main.ChangeButton.Text = $"Apply changes";
                 Main.ChangeButton.Enabled = false;
 
@@ -428,7 +429,7 @@ public static bool CheckDependencies(bool alertDepends = true)
                     {
                         var component = node.Tag as Component;
 
-                        if (component.Downloaded)
+                        if (ComponentTracker.Downloaded.Exists(c => c.ID == component.ID))
                         {
                             requiredDepends.AddRange(File.ReadLines(component.InfoFile).First().Split(' ').Skip(2).ToArray());
                         }
@@ -450,7 +451,7 @@ public static bool CheckDependencies(bool alertDepends = true)
                         {
                             node.Checked = true;
 
-                            if (ComponentTracker.Downloaded.Any(depend => depend.ID == component.ID))
+                            if (ComponentTracker.Downloaded.Exists(depend => depend.ID == component.ID))
                             {
                                 persistDepends.Add(component.Title);
                             }

FlashpointManager/src/Forms/Main.cs

@@ -74,7 +74,7 @@ public void ComponentList_AfterCheck(object sender, TreeViewEventArgs e)
 
                 var component = node.Tag as Component;
 
-                size += component.Downloaded
+                size += FPM.ComponentTracker.Downloaded.Exists(c => c.ID == component.ID)
                     ? long.Parse(File.ReadLines(component.InfoFile).First().Split(' ')[1])
                     : component.Size;
             });
@@ -122,8 +122,6 @@ private void ChangeButton_Click(object sender, EventArgs e)
 
         private void UpdateButton_Click(object sender, EventArgs e)
         {
-            FPM.CheckDependencies();
-
             FPM.UpdateMode = true;
 
             var downloadWindow = new Operate();

FlashpointManager/src/Forms/Operate.cs

@@ -73,7 +73,7 @@ private async void Operation_Load(object sender, EventArgs e)
                 }
             }
 
-            byteTotal = removedComponents.Concat(addedComponents).Sum(item => item.Size);
+            byteTotal = removedComponents.Concat(addedComponents).Sum(c => c.Size);
 
             foreach (var component in addedComponents)
             {