fix(firebaseRef): Do not return a modified firebase ref

Author: davideast

src/firebaseAuthService.js

@@ -2,7 +2,7 @@
   "use strict";
 
   function FirebaseAuthService($firebaseAuth, firebaseRef) {
-    return $firebaseAuth(firebaseRef);
+    return $firebaseAuth(firebaseRef.default);
   }
   FirebaseAuthService.$inject = ['$firebaseAuth', 'firebaseRef'];
 

src/firebaseRef.js

@@ -23,19 +23,13 @@
     };
 
     this.$$createRefsFromUrlConfig = function $$createMultipleRefs(urlConfig) {
+      var refs = {};
       var error = this.$$checkUrls(urlConfig);
       if (error) { throw error; }
-      var defaultUrl = urlConfig.default;
-      var defaultRef = new Firebase(defaultUrl);
-      delete urlConfig.default;
       angular.forEach(urlConfig, function(value, key) {
-        if (!defaultRef.hasOwnProperty(key)) {
-          defaultRef[key] = new Firebase(value);
-        } else {
-          throw new Error(key + ' is a reserved property name on firebaseRef.');
-        }
+        refs[key] = new Firebase(value);
       });
-      return defaultRef;
+      return refs;
     };
 
     this.$get = function FirebaseRef_$get() {

tests/unit/firebaseRef.spec.js

@@ -12,15 +12,15 @@ describe('firebaseRef', function () {
 
     it('creates a single reference with a url', inject(function() {
       firebaseRefProvider.registerUrl(MOCK_URL);
-      expect(firebaseRefProvider.$get()).toBeAFirebaseRef();
+      expect(firebaseRefProvider.$get().default).toBeAFirebaseRef();
     }));
 
     it('creates a default reference with a config object', inject(function() {
       firebaseRefProvider.registerUrl({
         default: MOCK_URL
       });
       var firebaseRef = firebaseRefProvider.$get();
-      expect(firebaseRef).toBeAFirebaseRef();
+      expect(firebaseRef.default).toBeAFirebaseRef();
     }));
 
     it('creates multiple references with a config object', inject(function() {
@@ -29,7 +29,7 @@ describe('firebaseRef', function () {
         messages: MOCK_URL + 'messages'
       });
       var firebaseRef = firebaseRefProvider.$get();
-      expect(firebaseRef).toBeAFirebaseRef();
+      expect(firebaseRef.default).toBeAFirebaseRef();
       expect(firebaseRef.messages).toBeAFirebaseRef();
     }));
 
@@ -41,16 +41,6 @@ describe('firebaseRef', function () {
       expect(errorWrapper).toThrow();
     }));
 
-    it('should throw an error when a reserved property is used', inject(function() {
-      function errorWrapper() {
-        firebaseRefProvider.registerUrl({
-          path: 'hello'
-        });
-        firebaseRefProvider.$get();
-      }
-      expect(errorWrapper).toThrow();
-    }));
-
   });
 
 });