Regression in 1.7.2 (wrt #53) causes `StackOverflowError` for some recursive types

[erdi]

After upgrading to 1.7.2 we are seeing StackOverflowError with the following stack trace:

java.lang.StackOverflowError: null
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:157)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)
    at com.fasterxml.classmate.ResolvedType.equals(ResolvedType.java:281)
    at com.fasterxml.classmate.types.ResolvedRecursiveType.equals(ResolvedRecursiveType.java:166)
    at com.fasterxml.classmate.TypeBindings.equals(TypeBindings.java:221)

I believe that this is due to the changes introduced in 57fb93a. FWIW, we're not calling classmate directly so it's hard for me to figure out what type actually causes this stack overflow but hopefully it will be fairly obvious to you.

[cowtowncoder]

@erdi First of all: thank you for reporting this!

Unfortunately it is not trivial to reproduce the issue (tried in #118) so I was hoping to get more information.
I realize this may not be easy to do but it would be really helpful.
One thing that might help, too, is knowing with JDK code is running? CI runs on JDKs 8.x, 17.x, 21.x and 25.x.

In the meantime, I will try to reproduce on my side.

[cowtowncoder]

Ok, never mind: with some more work, #118 does reproduce the issue.

[cowtowncoder]

Released 1.7.3 with the fix -- should be available via Maven Central soon.

Thank you @erdi for reporting the issue: and if you get a chance, would be good to verify that the fix works.

[erdi]

I'm glad that you eventually managed to figure it out with the limited report from me and I'm grateful that you released a new version with the fix so swiftly. I will have a stab at trying to figure out which type in our codebase is triggering this and come back to you with a confirmation of the fix being effective.

[cowtowncoder]

From the reproduction I have, the key seemed to be about caching, actually, more than type being resolved.
But it would definitely be good to see if this is the only problem and whether your case is fixed.

[erdi]

Sorry for the delay @cowtowncoder but I can now confirm that we no longer see this issue on 1.7.3.

[cowtowncoder]

@erdi Thank you for confirming.