Refactor CheckSuite initialization and add cleanup for singleton instance in configuration specs

Signed-off-by: Rodrigo Nardi <rnardi@netdef.org>

Author: RodrigoMNardi

lib/github/plan_execution/finished.rb

@@ -34,8 +34,12 @@ class Finished
       #
       # @param [Hash] payload The payload containing information about the CheckSuite.
       def initialize(payload)
-        @check_suite = CheckSuite.find_by(bamboo_ci_ref: payload['bamboo_ref']) if payload['bamboo_ref']
-        @check_suite = CheckSuite.find(payload['check_suite_id']) if payload['check_suite_id']
+        @check_suite = CheckSuite.where(
+          bamboo_ci_ref: payload['bamboo_ref']
+        ).or(
+          CheckSuite.where(id: payload['check_suite_id'])
+        ).last
+
         @logger = GithubLogger.instance.create('github_plan_execution_finished.log', Logger::INFO)
         @hanged = payload['hanged'] || false
       end

spec/lib/helpers/configuration_spec.rb

@@ -24,6 +24,12 @@
     end
   end
 
+  after do
+    if described_class.instance_variable_defined?(:@singleton__instance__)
+      described_class.__send__(:remove_instance_variable, :@singleton__instance__)
+    end
+  end
+
   describe '.instance' do
     it 'returns a singleton instance' do
       expect(described_class.instance).to be_a(described_class)