split 3 bug types with outside method code changes from all, i.e., exclude withinsinglemethod

Author: maxxbw54

All/.DS_Store

@@ -0,0 +1 @@
+Declaration redundancy

OutsideSingleMethod/FindBugs-MS_SHOULD_BE_FINAL/FBViolation#10134/comMsg.txt

@@ -0,0 +1,7 @@
+diff --git a/src/net/slipcor/pvparena/commands/PAA_Edit.java b/src/net/slipcor/pvparena/commands/PAA_Edit.java
+index 85f6171f..8e4000f2 100644
+--- a/src/net/slipcor/pvparena/commands/PAA_Edit.java
++++ b/src/net/slipcor/pvparena/commands/PAA_Edit.java
+@@ -26 +26 @@ public class PAA_Edit extends AbstractArenaCommand {
+-    public static Map<String, Arena> activeEdits = new HashMap<String, Arena>();
++    public static final Map<String, Arena> activeEdits = new HashMap<String, Arena>();

OutsideSingleMethod/FindBugs-MS_SHOULD_BE_FINAL/FBViolation#10134/diff.diff

@@ -0,0 +1,82 @@
+package net.slipcor.pvparena.commands;
+
+import net.slipcor.pvparena.arena.Arena;
+import net.slipcor.pvparena.core.Help;
+import net.slipcor.pvparena.core.Help.HELP;
+import net.slipcor.pvparena.core.Language;
+import net.slipcor.pvparena.core.Language.MSG;
+import org.bukkit.command.CommandSender;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * <pre>PVP Arena EDIT Command class</pre>
+ * <p/>
+ * A command to toggle an arena's edit mode
+ *
+ * @author slipcor
+ * @version v0.10.0
+ */
+
+public class PAA_Edit extends AbstractArenaCommand {
+
+    public static final Map<String, Arena> activeEdits = new HashMap<String, Arena>();
+
+    public PAA_Edit() {
+        super(new String[]{"pvparena.cmd.edit"});
+    }
+
+    @Override
+    public void commit(final Arena arena, final CommandSender sender, final String[] args) {
+        if (!this.hasPerms(sender, arena)) {
+            return;
+        }
+
+        if (!argCountValid(sender, arena, args, new Integer[]{0})) {
+            return;
+        }
+
+        String msg;
+
+        if (PAA_Edit.activeEdits.containsValue(arena)) {
+            activeEdits.remove(sender.getName());
+            msg = Language.parse(arena, MSG.ARENA_EDIT_DISABLED, arena.getName());
+        } else {
+            if (arena.isFightInProgress()) {
+                final PAA_Stop cmd = new PAA_Stop();
+                cmd.commit(arena, sender, new String[0]);
+            }
+            activeEdits.put(sender.getName(), arena);
+            msg = Language.parse(arena, MSG.ARENA_EDIT_ENABLED, arena.getName());
+        }
+        arena.msg(sender, msg);
+    }
+
+    @Override
+    public String getName() {
+        return this.getClass().getName();
+    }
+
+    @Override
+    public void displayHelp(final CommandSender sender) {
+        Arena.pmsg(sender, Help.parse(HELP.EDIT));
+    }
+
+    @Override
+    public List<String> getMain() {
+        return Arrays.asList("edit");
+    }
+
+    @Override
+    public List<String> getShort() {
+        return Arrays.asList("!e");
+    }
+
+    @Override
+    public CommandTree<String> getSubs(final Arena arena) {
+        return new CommandTree<String>(null);
+    }
+}

OutsideSingleMethod/FindBugs-MS_SHOULD_BE_FINAL/FBViolation#10134/new/PAA_Edit.java

@@ -0,0 +1,82 @@
+package net.slipcor.pvparena.commands;
+
+import net.slipcor.pvparena.arena.Arena;
+import net.slipcor.pvparena.core.Help;
+import net.slipcor.pvparena.core.Help.HELP;
+import net.slipcor.pvparena.core.Language;
+import net.slipcor.pvparena.core.Language.MSG;
+import org.bukkit.command.CommandSender;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * <pre>PVP Arena EDIT Command class</pre>
+ * <p/>
+ * A command to toggle an arena's edit mode
+ *
+ * @author slipcor
+ * @version v0.10.0
+ */
+
+public class PAA_Edit extends AbstractArenaCommand {
+
+    public static Map<String, Arena> activeEdits = new HashMap<String, Arena>();
+
+    public PAA_Edit() {
+        super(new String[]{"pvparena.cmd.edit"});
+    }
+
+    @Override
+    public void commit(final Arena arena, final CommandSender sender, final String[] args) {
+        if (!this.hasPerms(sender, arena)) {
+            return;
+        }
+
+        if (!argCountValid(sender, arena, args, new Integer[]{0})) {
+            return;
+        }
+
+        String msg;
+
+        if (PAA_Edit.activeEdits.containsValue(arena)) {
+            activeEdits.remove(sender.getName());
+            msg = Language.parse(arena, MSG.ARENA_EDIT_DISABLED, arena.getName());
+        } else {
+            if (arena.isFightInProgress()) {
+                final PAA_Stop cmd = new PAA_Stop();
+                cmd.commit(arena, sender, new String[0]);
+            }
+            activeEdits.put(sender.getName(), arena);
+            msg = Language.parse(arena, MSG.ARENA_EDIT_ENABLED, arena.getName());
+        }
+        arena.msg(sender, msg);
+    }
+
+    @Override
+    public String getName() {
+        return this.getClass().getName();
+    }
+
+    @Override
+    public void displayHelp(final CommandSender sender) {
+        Arena.pmsg(sender, Help.parse(HELP.EDIT));
+    }
+
+    @Override
+    public List<String> getMain() {
+        return Arrays.asList("edit");
+    }
+
+    @Override
+    public List<String> getShort() {
+        return Arrays.asList("!e");
+    }
+
+    @Override
+    public CommandTree<String> getSubs(final Arena arena) {
+        return new CommandTree<String>(null);
+    }
+}

OutsideSingleMethod/FindBugs-MS_SHOULD_BE_FINAL/FBViolation#10134/old/PAA_Edit.java

@@ -0,0 +1,8 @@
+Id:10134
+comSha:82db803fad264e008c6fc17e9a7b95527505616e
+parentComSha:5e4277b6ca35071da3e9df92c84d081d4119a176
+BuggyFilePath:src/net/slipcor/pvparena/commands/PAA_Edit.java
+FixedFilePath:src/net/slipcor/pvparena/commands/PAA_Edit.java
+StartLineNum:26
+EndLineNum:26
+repoName:slipcor#pvparena

OutsideSingleMethod/FindBugs-MS_SHOULD_BE_FINAL/FBViolation#10134/pair.info

@@ -0,0 +1 @@
+Declaration redundancy

OutsideSingleMethod/FindBugs-MS_SHOULD_BE_FINAL/FBViolation#10328/comMsg.txt

@@ -0,0 +1,16 @@
+diff --git a/src/net/slipcor/pvparena/core/StringParser.java b/src/net/slipcor/pvparena/core/StringParser.java
+index 93d4dcf3..40e52002 100644
+--- a/src/net/slipcor/pvparena/core/StringParser.java
++++ b/src/net/slipcor/pvparena/core/StringParser.java
+@@ -35 +35 @@ public final class StringParser {
+-    public static final Debug DEBUG = new Debug(17);
++    private static final Debug DEBUG = new Debug(17);
+@@ -40 +40 @@ public final class StringParser {
+-    public static Set<String> positive = new HashSet<String>(Arrays.asList(
++    public static final Set<String> positive = new HashSet<String>(Arrays.asList(
+@@ -42 +42 @@ public final class StringParser {
+-    public static Set<String> negative = new HashSet<String>(Arrays.asList(
++    public static final Set<String> negative = new HashSet<String>(Arrays.asList(
+@@ -587 +587 @@ public final class StringParser {
+-    public static String getWoolEnumFromChatColorEnum(final String color) {
++    private static String getWoolEnumFromChatColorEnum(final String color) {