Skip to content

Commit b453b3d

Browse files
committed
Merge branch '302_requirements_sys_fix' into 'master'
Restructure the way rawFileReader sources dotnet library and fix requirements Closes #180 and #177 See merge request mass-spectrometry/corems!143
2 parents 9e999ef + eba7c3e commit b453b3d

29 files changed

Lines changed: 8830 additions & 8829 deletions

.bumpversion.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[bumpversion]
2-
current_version = 3.0.2
2+
current_version = 3.1.0
33
commit = False
44
tag = False
55

Makefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,12 @@ patch:
2323

2424
@bumpversion patch --allow-dirty
2525

26+
pypi_test:
27+
@rm -rf build dist *.egg-info
28+
@python3 setup.py sdist
29+
2630
pypi:
27-
31+
@rm -rf build dist *.egg-info
2832
@python3 setup.py sdist
2933
@twine upload dist/*
3034

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ CoreMS aims to provide
4949

5050
## Current Version
5151

52-
`3.0.2`
52+
`3.1.0`
5353

5454
***
5555

@@ -335,11 +335,11 @@ UML (unified modeling language) diagrams for Direct Infusion FT-MS and GC-MS cla
335335
336336
If you use CoreMS in your work, please use the following citation:
337337
338-
Version [3.0.2 Release on GitHub](https://github.com/EMSL-Computing/CoreMS/releases/tag/v3.0.2), archived on Zenodo:
338+
Version [3.1.0 Release on GitHub](https://github.com/EMSL-Computing/CoreMS/releases/tag/v3.1.0), archived on Zenodo:
339339
340340
[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.14009575.svg)](https://doi.org/10.5281/zenodo.14009575)
341341
342-
Yuri E. Corilo, William R. Kew, Lee Ann McCue, Katherine R . Heal, James C. Carr (2024, October 29). EMSL-Computing/CoreMS: CoreMS 3.0.2 (Version v3.0.2), as developed on Github. Zenodo. http://doi.org/10.5281/zenodo.14009575
342+
Yuri E. Corilo, William R. Kew, Lee Ann McCue, Katherine R . Heal, James C. Carr (2024, October 29). EMSL-Computing/CoreMS: CoreMS 3.1.0 (Version v3.1.0), as developed on Github. Zenodo. http://doi.org/10.5281/zenodo.14009575
343343
344344
```
345345

corems/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
__author__ = "Yuri E. Corilo"
2-
__version__ = "3.0.2"
2+
__version__ = "3.1.0"
33
import time
44
import os
55
import sys

corems/mass_spectra/input/massList.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
import sys
55

6-
sys.path.append(".") # Why?
76
from pathlib import Path
87
from threading import Thread
98
import warnings

corems/mass_spectra/input/rawFileReader.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
import site
1515
from pathlib import Path
1616
import datetime
17+
import importlib.util
18+
import os
1719

1820
import clr
1921
import pandas as pd
@@ -31,9 +33,9 @@
3133
from corems.encapsulation.factory.parameters import LCMSParameters, default_parameters
3234
from corems.mass_spectra.input.parserbase import SpectraParserInterface
3335

34-
# do not change the order from the imports statements and reference ThermoFisher below
35-
sys.path.append(site.getsitepackages()[0] + "/ext_lib/dotnet/")
36-
sys.path.append("ext_lib/dotnet/")
36+
# Add the path of the Thermo .NET libraries to the system path
37+
spec = importlib.util.find_spec("corems")
38+
sys.path.append(str(Path(os.path.dirname(spec.origin)).parent) + "/ext_lib/dotnet/")
3739

3840
clr.AddReference("ThermoFisher.CommonCore.RawFileReader")
3941
clr.AddReference("ThermoFisher.CommonCore.Data")

corems/molecular_formula/input/masslist_ref.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99

1010
import pandas as pd
1111

12-
sys.path.append(".")
13-
1412
from corems.encapsulation.constant import Atoms, Labels
1513
from corems.molecular_formula.factory.MolecularFormulaFactory import (
1614
LCMSLibRefMolecularFormula,

corems/molecular_id/factory/molecularSQL.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import sys
22

3-
sys.path.append(".")
43
import json
54
import os
65

corems/molecular_id/search/priorityAssignment.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import os
22
import sys
33

4-
sys.path.append(".")
54
from copy import deepcopy
65
from threading import Thread
76
from itertools import product

docs/corems.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ <h1 id="corems">CoreMS</h1>
154154

155155
<h2 id="current-version">Current Version</h2>
156156

157-
<p><code>3.0.2</code></p>
157+
<p><code>3.1.0</code></p>
158158

159159
<hr />
160160

@@ -487,11 +487,11 @@ <h2 id="citing-corems">Citing CoreMS</h2>
487487

488488
<p>If you use CoreMS in your work, please use the following citation:</p>
489489

490-
<p>Version <a href="https://github.com/EMSL-Computing/CoreMS/releases/tag/v3.0.2">3.0.2 Release on GitHub</a>, archived on Zenodo: </p>
490+
<p>Version <a href="https://github.com/EMSL-Computing/CoreMS/releases/tag/v3.1.0">3.1.0 Release on GitHub</a>, archived on Zenodo: </p>
491491

492492
<p><a href="https://doi.org/10.5281/zenodo.14009575"><img src="https://zenodo.org/badge/DOI/10.5281/zenodo.14009575.svg" alt="DOI" /></a></p>
493493

494-
<p>Yuri E. Corilo, William R. Kew, Lee Ann McCue, Katherine R . Heal, James C. Carr (2024, October 29). EMSL-Computing/CoreMS: CoreMS 3.0.2 (Version v3.0.2), as developed on Github. Zenodo. <a href="http://doi.org/10.5281/zenodo.14009575">http://doi.org/10.5281/zenodo.14009575</a></p>
494+
<p>Yuri E. Corilo, William R. Kew, Lee Ann McCue, Katherine R . Heal, James C. Carr (2024, October 29). EMSL-Computing/CoreMS: CoreMS 3.1.0 (Version v3.1.0), as developed on Github. Zenodo. <a href="http://doi.org/10.5281/zenodo.14009575">http://doi.org/10.5281/zenodo.14009575</a></p>
495495

496496
<p>```</p>
497497

@@ -527,7 +527,7 @@ <h2 id="citing-corems">Citing CoreMS</h2>
527527
<label class="view-source-button" for="mod-corems-view-source"><span>View Source</span></label>
528528

529529
<div class="pdoc-code codehilite"><pre><span></span><span id="L-1"><a href="#L-1"><span class="linenos"> 1</span></a><span class="n">__author__</span> <span class="o">=</span> <span class="s2">&quot;Yuri E. Corilo&quot;</span>
530-
</span><span id="L-2"><a href="#L-2"><span class="linenos"> 2</span></a><span class="n">__version__</span> <span class="o">=</span> <span class="s2">&quot;3.0.2&quot;</span>
530+
</span><span id="L-2"><a href="#L-2"><span class="linenos"> 2</span></a><span class="n">__version__</span> <span class="o">=</span> <span class="s2">&quot;3.1.0&quot;</span>
531531
</span><span id="L-3"><a href="#L-3"><span class="linenos"> 3</span></a><span class="kn">import</span> <span class="nn">time</span>
532532
</span><span id="L-4"><a href="#L-4"><span class="linenos"> 4</span></a><span class="kn">import</span> <span class="nn">os</span>
533533
</span><span id="L-5"><a href="#L-5"><span class="linenos"> 5</span></a><span class="kn">import</span> <span class="nn">sys</span>

0 commit comments

Comments
 (0)