Skip to content

Commit 4d5388c

Browse files
committed
Merge in code from master into branch and solve conflicts
2 parents 40ec5d7 + ad375d0 commit 4d5388c

26 files changed

Lines changed: 44508 additions & 2298 deletions

corems/encapsulation/factory/processingSetting.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ def __post_init__(self):
6767
'Res.': Labels.rp,
6868
'resolution': Labels.rp,
6969
'Intensity': Labels.abundance,
70+
'Peak Height': Labels.abundance,
7071
'I': Labels.abundance,
7172
'Abundance': Labels.abundance,
7273
'abs_abu': Labels.abundance,
@@ -214,6 +215,7 @@ class MassSpectrumSetting:
214215
Maximum m/z to use for peak picking. Default is 1200.0.
215216
picking_point_extrapolate : int, optional
216217
How many data points (in each direction) to extrapolate the mz axis and 0 pad the abundance axis. Default is 3.
218+
Recommend 3 for reduced profile data or if peak picking faults
217219
calib_minimize_method : str, optional
218220
Minimization method to use for calibration. Default is 'Powell'.
219221
calib_pol_order : int, optional
@@ -256,7 +258,7 @@ class MassSpectrumSetting:
256258
# How many data points (in each direction) to extrapolate the mz axis and 0 pad the abundance axis
257259
# This will fix peak picking at spectrum limit issues
258260
# 0 to keep normal behaviour, typical value 3 to fix
259-
picking_point_extrapolate: int = 0
261+
picking_point_extrapolate: int = 3
260262

261263
calib_minimize_method: str = 'Powell'
262264
calib_pol_order: int = 2
@@ -313,6 +315,9 @@ class MassSpecPeakSetting:
313315
legacy_resolving_power : bool, optional
314316
Flag indicating whether to use the legacy (CoreMS v1) resolving power calculation.
315317
Defaults to True.
318+
centroid_legacy_polyfit : bool, optional
319+
Use legacy (numpy polyfit) to fit centroid
320+
Default false.
316321
"""
317322

318323
kendrick_base: Dict = dataclasses.field(default_factory=dict)
@@ -332,7 +337,10 @@ class MassSpecPeakSetting:
332337
peak_height_max_percent: float = 10 # 1-100 % used for baseline detection
333338

334339
legacy_resolving_power: bool = True # Use the legacy (CoreMS v1) resolving power calculation (True)
335-
340+
# TODO revisit this default
341+
342+
centroid_legacy_polyfit: bool = False
343+
336344
def __post_init__(self):
337345

338346
# default to CH2

0 commit comments

Comments
 (0)