Skip to content

Commit ceaf879

Browse files
fix: pin macOS setup.sh's llvm install to llvm@19, matches CI's own fix
The unversioned `llvm` formula (currently 23.x) has no homebrew-core bottle for Intel macOS or macOS 14, so `brew install llvm` was silently falling back to a multi-hour from-source build on those runners -- confirmed via formulae.brew.sh's bottle listing. llvm@19 has bottles for both and still satisfies SpiderMonkey's >=19 requirement. Mirrors the same fix already applied to the workflow's own build-and-test step. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 2f6a35f commit ceaf879

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

‎setup.sh‎

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,18 @@ elif [[ "$OSTYPE" == "darwin"* ]]; then # macOS
3232
brew install lld
3333
# Xcode's bundled clang (16-17 on current runner images) is older than
3434
# SpiderMonkey's own minimum at the current mozcentral.version pin (>=19,
35-
# per its own configure error) -- homebrew's llvm keg isn't symlinked onto
36-
# PATH by default, so put it first explicitly for the rest of this script.
37-
brew install llvm
38-
export PATH="$(brew --prefix llvm)/bin:$PATH"
35+
# per its own configure error). Pinned to the major-19 formula rather than
36+
# unversioned `llvm` (currently 23.x): homebrew-core only publishes bottles
37+
# for `llvm` on recent arm64 macOS + Linux, so on Intel macOS and macOS 14
38+
# runners `brew install llvm` silently falls back to a from-source build
39+
# (multi-hour, "Tier 3" unsupported) instead of installing a bottle --
40+
# confirmed via https://formulae.brew.sh/api/formula/llvm.json's bottle
41+
# list lacking any Intel or "sonoma" entry, versus llvm@19's, which has
42+
# both. 19.x still satisfies the >=19 requirement.
43+
# homebrew's llvm keg isn't symlinked onto PATH by default, so put it
44+
# first explicitly for the rest of this script.
45+
brew install llvm@19
46+
export PATH="$(brew --prefix llvm@19)/bin:$PATH"
3947
elif [[ "$OSTYPE" == "msys"* || "$OSTYPE" == "cygwin"* ]]; then # Windows
4048
echo "Dependencies are not going to be installed automatically on Windows."
4149
else

0 commit comments

Comments
 (0)