Skip to content

Commit 3ddea7f

Browse files
Correct doc: ubuntu CI fix is written but not pushed (needs workflow scope)
Follow-up to 4ef9df7 -- that commit's doc update described the ubuntu LLVM bump as already applied, but it was split into a separate, currently-unpushed change since it touches a workflow YAML file this session's push credentials aren't scoped for. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 4ef9df7 commit 3ddea7f

1 file changed

Lines changed: 21 additions & 13 deletions

File tree

‎SPIDERMONKEY_VERSION_BUMP.md‎

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -183,21 +183,29 @@ overridden locally on one machine.
183183
Confirmed via the actual GitHub Actions logs for this PR (all 5 platforms
184184
failed, all for a version of this same reason):
185185

186-
- **ubuntu (x64 and arm)**: `.github/workflows/test-and-publish.yaml`'s
187-
"Setup LLVM" step explicitly installed LLVM 18 (`./llvm.sh 18`) — bumped
188-
to 19, matching `configure`'s own `Only clang/llvm 19.0 or newer is
189-
supported` error.
190186
- **macOS (macos-14, macos-15-intel)**: no explicit LLVM install existed at
191187
all — the build was relying on Xcode's bundled clang (16.0.0 and 17.0.6 on
192-
the current runner images respectively), both below the same >=19
193-
requirement. Added `brew install llvm` plus putting its bin dir first on
194-
`PATH` in `setup.sh`'s own macOS branch (homebrew's llvm keg isn't
195-
symlinked onto PATH by default).
196-
- **Windows**: covered by the rustc 1.90.0 bump above.
197-
198-
None of this had been verified against real CI before — the "Testing"
199-
section below was checked against local builds and a real network job, not
200-
a green CI run. See that section for the corrected status.
188+
the current runner images respectively), both below the >=19 requirement.
189+
**Fixed, committed**: added `brew install llvm` plus putting its bin dir
190+
first on `PATH` in `setup.sh`'s own macOS branch (homebrew's llvm keg
191+
isn't symlinked onto PATH by default).
192+
- **Windows**: covered by the rustc 1.90.0 bump above. **Fixed, committed.**
193+
- **ubuntu (x64 and arm)**: `.github/workflows/test-and-publish.yaml`'s
194+
"Setup LLVM" step explicitly installs LLVM 18 (`./llvm.sh 18`), which also
195+
needs bumping to 19 to match `configure`'s own `Only clang/llvm 19.0 or
196+
newer is supported` error. **Diagnosed, fix written, but not yet pushed**
197+
— it edits a workflow file, which needs `workflow` OAuth scope this
198+
session's push credentials don't have. Someone with that scope needs to
199+
push it (or make the equivalent edit via the GitHub UI) before ubuntu CI
200+
will go green.
201+
202+
None of this had been verified against real CI before this pass — the
203+
"Testing" section below was checked against local builds and a real network
204+
job, not a green CI run. See that section for the corrected status. As of
205+
this writing, macOS and Windows CI have not yet been re-run against the
206+
fix above (pushed, awaiting the next CI run); ubuntu CI is still expected
207+
to fail until the held-back workflow-file fix is applied by someone with
208+
the right push scope.
201209

202210
### 4. `CMakeLists.txt` — `XP_WIN` now defined globally for the Windows build
203211

0 commit comments

Comments
 (0)