A few fixes

 - Fix client-side crash
 - Make the mod loadable in a dev environment
 - Fix error spam with newest mixin

Author: Runemoro

src/main/java/org/dimdev/vanillafix/VanillaFixLoadingPlugin.java

@@ -22,11 +22,10 @@
 import java.util.Map;
 
 @IFMLLoadingPlugin.MCVersion(ForgeVersion.mcVersion)
-@IFMLLoadingPlugin.SortingIndex(-10000)
-@IFMLLoadingPlugin.TransformerExclusions("org.dimdev.vanillafix.")
+@IFMLLoadingPlugin.SortingIndex(-100000)
 public class VanillaFixLoadingPlugin implements IFMLLoadingPlugin {
     private static final Logger log = LogManager.getLogger();
-    private static final String MCP_VERSION = "20180601-1.12"; // TODO: Use version for current Minecraft version!
+    private static final String MCP_VERSION = "20180618-1.12"; // TODO: Use version for current Minecraft version!
     private static boolean initialized = false;
 
     public static LoadingConfig config;

src/main/java/org/dimdev/vanillafix/crashes/CrashUtils.java

@@ -19,10 +19,11 @@ public static void crash(CrashReport report) {
 
     public static void warn(CrashReport report) {
         if (isClient()) {
-            // TODO: what if there's several exceptions in a row?
             outputReport(report);
-            Minecraft.getMinecraft().addScheduledTask(() -> Minecraft.getMinecraft().displayGuiScreen(new GuiWarningScreen(report, Minecraft.getMinecraft().currentScreen)));
-        } else {
+            // Don't inline showWarningScreen, that will cause Java to load the GuiScreen
+            // class on servers, because of the lambda!
+            ((IPatchedMinecraft) Minecraft.getMinecraft()).showWarningScreen(report);
+            } else {
             log.fatal(report.getDescription(), report.getCrashCause());
         }
     }

src/main/java/org/dimdev/vanillafix/crashes/IPatchedMinecraft.java

@@ -4,5 +4,6 @@
 
 public interface IPatchedMinecraft {
     boolean shouldCrashIntegratedServerNextTick();
+    void showWarningScreen(CrashReport report);
     void makeErrorNotification(CrashReport report);
 }

src/main/java/org/dimdev/vanillafix/crashes/mixins/client/MixinMinecraft.java

@@ -381,10 +381,6 @@ private long checkForF3C(Minecraft mc) {
         return -1;
     }
 
-    private void breakRendering() {
-        getTextureManager().bindTexture(Gui.OPTIONS_BACKGROUND);
-    }
-
     /** @reason Disables the vanilla F3 + C logic. */
     @Redirect(method = "runTickKeyboard", at = @At(value = "INVOKE", target = "Lorg/lwjgl/input/Keyboard;isKeyDown(I)Z", ordinal = 0))
     private boolean isKeyDownF3(int key) {
@@ -416,8 +412,14 @@ private void checkForCtrlI(CallbackInfo ci) {
             ProblemToast lastToast = getToastGui().getToast(ProblemToast.class, IToast.NO_TOKEN);
             if (lastToast != null) {
                 lastToast.hide = true;
-                displayGuiScreen(new GuiWarningScreen(lastToast.report, Minecraft.getMinecraft().currentScreen));
+                displayGuiScreen(new GuiWarningScreen(lastToast.report, currentScreen));
             }
         }
     }
+
+    @Override
+    public void showWarningScreen(CrashReport report) {
+        // TODO: runGuiLoop instead, to prevent errors from happening while the warning screen is open?
+        addScheduledTask(() -> displayGuiScreen(new GuiWarningScreen(report, currentScreen)));
+    }
 }