Skip to content

Commit def0003

Browse files
committed
Remove usages of Throwables to fix deprecation warnings
1 parent e7c1878 commit def0003

13 files changed

Lines changed: 71 additions & 52 deletions

src/main/java/net/minecraftforge/gradle/common/BasePlugin.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import java.lang.reflect.Type;
2929
import java.net.HttpURLConnection;
3030
import java.net.URL;
31-
import java.util.Arrays;
3231
import java.util.Collections;
3332
import java.util.List;
3433
import java.util.Map;
@@ -446,9 +445,9 @@ public Boolean call()
446445
Files.write(buf.toString().getBytes(Charsets.UTF_8), delayedFile("jsons/" + Constants.REPLACE_MC_VERSION + ".json").call());
447446
}
448447
}
449-
catch (Throwable t)
448+
catch (IOException e)
450449
{
451-
Throwables.propagate(t);
450+
throw new RuntimeException(e);
452451
}
453452
return true;
454453
}
@@ -772,7 +771,7 @@ else if (con.getResponseCode() == 200)
772771
}
773772
catch (IOException e)
774773
{
775-
Throwables.propagate(e);
774+
throw new RuntimeException(e);
776775
}
777776
}
778777

@@ -801,10 +800,10 @@ protected Version parseAndStoreVersion(File file, File... inheritanceDirs)
801800
{
802801
version = JsonFactory.loadVersion(file, delayedString(REPLACE_MC_VERSION).call(), inheritanceDirs);
803802
}
804-
catch (Exception e)
803+
catch (IOException e)
805804
{
806805
LOGGER.error("" + file + " could not be parsed");
807-
Throwables.propagate(e);
806+
throw new RuntimeException(e);
808807
}
809808
}
810809

src/main/java/net/minecraftforge/gradle/patcher/TaskExtractExcModifiers.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,14 @@
3636
import org.objectweb.asm.Opcodes;
3737

3838
import com.google.common.base.Charsets;
39-
import com.google.common.base.Throwables;
4039
import com.google.common.io.ByteStreams;
4140
import com.google.common.io.Files;
4241

4342
class TaskExtractExcModifiers extends DefaultTask
4443
{
4544
@InputFile
4645
private Object inJar;
47-
46+
4847
@OutputFile
4948
private Object outExc;
5049

@@ -53,11 +52,11 @@ class TaskExtractExcModifiers extends DefaultTask
5352
* Default is for minecraft
5453
*/
5554
String matchingPrefix = "net/minecraft/";
56-
55+
5756
//@formatter:off
5857
public TaskExtractExcModifiers() { super(); }
5958
//@formatter:on
60-
59+
6160
@TaskAction
6261
public void doStuff() throws IOException
6362
{
@@ -69,7 +68,7 @@ public void doStuff() throws IOException
6968

7069
output.getParentFile().mkdirs();
7170
output.createNewFile();
72-
71+
7372
try (BufferedWriter writer = Files.newWriter(output, Charsets.UTF_8);
7473
ZipInputStream zin = new ZipInputStream(new FileInputStream(input)))
7574
{
@@ -94,7 +93,7 @@ public void doStuff() throws IOException
9493
}
9594
}
9695
}
97-
96+
9897
private static class GenerateMapClassAdapter extends ClassVisitor
9998
{
10099
String className;
@@ -132,7 +131,7 @@ public MethodVisitor visitMethod(int access, String name, String desc, String si
132131
}
133132
catch (IOException e)
134133
{
135-
Throwables.propagate(e);
134+
throw new RuntimeException(e);
136135
}
137136
return super.visitMethod(access, name, desc, signature, exceptions);
138137
}

src/main/java/net/minecraftforge/gradle/tasks/ApplyS2STask.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
import com.google.common.base.Charsets;
4646
import com.google.common.base.Joiner;
4747
import com.google.common.base.Strings;
48-
import com.google.common.base.Throwables;
4948
import com.google.common.collect.Lists;
5049
import com.google.common.collect.Maps;
5150
import com.google.common.io.Files;
@@ -287,10 +286,8 @@ private FileCollection generateDefaultExc(File modifiers, FileCollection current
287286
}
288287
catch (IOException e)
289288
{
290-
Throwables.propagate(e);
289+
throw new RuntimeException(e);
291290
}
292-
293-
return null;
294291
}
295292

296293
@InputFiles @SkipWhenEmpty

src/main/java/net/minecraftforge/gradle/tasks/CreateStartTask.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import java.util.Set;
3131

3232
import net.minecraftforge.gradle.common.Constants;
33+
import net.minecraftforge.gradle.util.ThrowableUtil;
3334
import net.minecraftforge.gradle.util.caching.Cached;
3435
import net.minecraftforge.gradle.util.caching.CachedTask;
3536

@@ -206,10 +207,9 @@ private String getResource(URL resource)
206207
{
207208
return Resources.toString(resource, Charsets.UTF_8);
208209
}
209-
catch (Exception e)
210+
catch (IOException e)
210211
{
211-
Throwables.propagate(e);
212-
return "";
212+
throw new RuntimeException(e);
213213
}
214214
}
215215

src/main/java/net/minecraftforge/gradle/tasks/CrowdinDownload.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import com.google.common.base.Charsets;
4444
import com.google.common.base.Splitter;
4545
import com.google.common.base.Strings;
46-
import com.google.common.base.Throwables;
4746
import com.google.common.collect.Iterables;
4847
import com.google.common.io.CharStreams;
4948
import com.google.common.io.Files;
@@ -118,10 +117,10 @@ private void exportLocalizations(String projectId, String key) throws IOExceptio
118117
{
119118
con.connect();
120119
}
121-
catch (Throwable e)
120+
catch (IOException e)
122121
{
123122
// just in case people dont have internet at the moment.
124-
Throwables.propagate(e);
123+
throw new RuntimeException(e);
125124
}
126125

127126
int reponse = con.getResponseCode();

src/main/java/net/minecraftforge/gradle/tasks/PatchSourcesTask.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929

3030
import net.minecraftforge.gradle.common.Constants;
3131
import net.minecraftforge.gradle.util.GradleConfigurationException;
32+
import net.minecraftforge.gradle.util.ThrowableUtil;
3233
import net.minecraftforge.gradle.util.patching.ContextualPatch;
3334
import net.minecraftforge.gradle.util.patching.ContextualPatch.PatchStatus;
3435

@@ -45,7 +46,6 @@
4546
import com.cloudbees.diff.PatchException;
4647
import com.google.common.base.Charsets;
4748
import com.google.common.base.Joiner;
48-
import com.google.common.base.Throwables;
4949
import com.google.common.collect.Lists;
5050
import com.google.common.io.Files;
5151

@@ -291,7 +291,7 @@ else if (report.getStatus() == ContextualPatch.PatchStatus.Fuzzed)
291291

292292
if (failure != null && failOnError)
293293
{
294-
Throwables.propagate(failure);
294+
ThrowableUtil.propagate(failure);
295295
}
296296

297297
if (fuzzed)

src/main/java/net/minecraftforge/gradle/tasks/PostDecompileTask.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import java.util.zip.ZipEntry;
3535

3636
import net.minecraftforge.gradle.common.Constants;
37+
import net.minecraftforge.gradle.util.ThrowableUtil;
3738
import net.minecraftforge.gradle.util.caching.Cached;
3839
import net.minecraftforge.gradle.util.delayed.DelayedFile;
3940
import net.minecraftforge.gradle.util.mcp.FFPatcher;
@@ -55,7 +56,6 @@
5556
import com.github.abrarsyed.jastyle.OptParser;
5657
import com.google.common.base.Charsets;
5758
import com.google.common.base.Joiner;
58-
import com.google.common.base.Throwables;
5959
import com.google.common.collect.ArrayListMultimap;
6060
import com.google.common.collect.Lists;
6161
import com.google.common.collect.Multimap;
@@ -251,7 +251,7 @@ else if (report.getStatus() == PatchStatus.Fuzzed) // catch fuzzed patches
251251
if (fuzzed)
252252
getLogger().lifecycle("Patches Fuzzed!");
253253
if (error != null) {
254-
Throwables.propagate(error);
254+
ThrowableUtil.propagate(error);
255255
}
256256
}
257257

src/main/java/net/minecraftforge/gradle/tasks/SplitJarTask.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@
4242
import org.gradle.api.tasks.util.PatternFilterable;
4343
import org.gradle.api.tasks.util.PatternSet;
4444

45-
import com.google.common.base.Throwables;
46-
4745
public class SplitJarTask extends CachedTask implements PatternFilterable
4846
{
4947
@InputFile
@@ -111,7 +109,7 @@ public void visitFile(FileVisitDetails details)
111109
}
112110
catch (IOException e)
113111
{
114-
Throwables.propagate(e);
112+
throw new RuntimeException(e);
115113
}
116114
}
117115
});

src/main/java/net/minecraftforge/gradle/user/TaskRecompileMc.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
import org.gradle.api.tasks.OutputFile;
4343
import org.gradle.api.tasks.TaskAction;
4444

45-
import com.google.common.base.Throwables;
4645
import com.google.common.collect.ImmutableMap;
4746
import com.google.common.collect.Sets;
4847
import com.google.common.io.Files;
@@ -191,7 +190,7 @@ public void visitDir(FileVisitDetails dir)
191190
}
192191
catch (IOException e)
193192
{
194-
Throwables.propagate(e);
193+
throw new RuntimeException(e);
195194
}
196195
}
197196

@@ -212,7 +211,7 @@ public void visitFile(FileVisitDetails file)
212211
}
213212
catch (IOException e)
214213
{
215-
Throwables.propagate(e);
214+
throw new RuntimeException(e);
216215
}
217216
}
218217
}

src/main/java/net/minecraftforge/gradle/user/patcherUser/TaskApplyBinPatches.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import java.io.FileInputStream;
2727
import java.io.FileOutputStream;
2828
import java.io.IOException;
29-
import java.nio.file.*;
3029
import java.util.Collections;
3130
import java.util.HashMap;
3231
import java.util.HashSet;
@@ -48,7 +47,6 @@
4847
import org.gradle.api.tasks.TaskAction;
4948

5049
import com.google.common.base.Joiner;
51-
import com.google.common.base.Throwables;
5250
import com.google.common.collect.Maps;
5351
import com.google.common.io.ByteArrayDataInput;
5452
import com.google.common.io.ByteStreams;
@@ -168,7 +166,7 @@ public void visitFile(FileVisitDetails file)
168166
}
169167
catch (IOException e)
170168
{
171-
throw Throwables.propagate(e);
169+
throw new RuntimeException(e);
172170
}
173171
}
174172

@@ -197,9 +195,9 @@ public void setup()
197195
}
198196
bytes = jarBytes.toByteArray();
199197
}
200-
catch (Exception e)
198+
catch (IOException e)
201199
{
202-
throw Throwables.propagate(e);
200+
throw new RuntimeException(e);
203201
}
204202

205203
log("Reading Patches:");
@@ -223,7 +221,7 @@ public void setup()
223221
}
224222
catch (IOException e)
225223
{
226-
throw Throwables.propagate(e);
224+
throw new RuntimeException(e);
227225
}
228226
log("Read %d binary patches", patchlist.size());
229227
log("Patch list :\n\t%s", Joiner.on("\n\t").join(patchlist.entrySet()));

0 commit comments

Comments
 (0)